221753 - cfl.ca - uses proprietary JS

Status: RESOLVED INCOMPLETE

(Tech Evangelism Graveyard :: English Other, defect)

Description

[Eric Lavoie]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20030925
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20030925

Fails to display the box with the games this week, the welcome page has a box
that displays the games coming this week, it shows it empty with only the
navigation buttons, in explorer the games do show up.

Reproducible: Always

Steps to Reproduce:
1. open the page and look :)
2.
3.

Actual Results:  
box is empty

Expected Results:  
should have showed the games

Comment 1

[[:nickname]]

The bug is in http://www.canoe.ca/CFLIncludes/cfl_thisweek_menu.js , a script
which is externally included in this page. This code is very old and only
written for ns4 & ie4 (!) as one can see from the source:

<!-- Begin

ns4 = (document.layers)? true:false
ie4 = (document.all)? true:false

function init() {
	if (ns4) {block1 = document.submenu1; 
			  block1.visibility = "visible";
			  block2 = document.submenu2; 
			  block2.visibility = "hide"; 
              }
	if (ie4) {block1 = submenu1.style; 
			  block1.visibility = "visible";
			  block2 = submenu2.style; 
			  block2.visibility = "hidden";
  }
}

// Show/Hide functions for pointer objects

function showObject(obj) {
	if (ns4) {obj.visibility = "show";}
	else if (ie4) {obj.visibility = "visible"}
}

function hideObject(obj) {
	if (ns4) {obj.visibility = "hide"}
	else if (ie4) {obj.visibility = "hidden"}
}


// End -->


IMHO an evangelism issue; someone should tell them that their code is very
outdated (and most of the time full of errors; like using javascript: protocoll
in onmouse* handlers at http://cfl.ca/)

Comment 2

[Bill Mason]

The script that operates that box
(http://www.canoe.ca/CFLIncludes/cfl_thisweek_menu.js) is written for IE or
Netscape 4 only.

ns4 = (document.layers)? true:false
ie4 = (document.all)? true:false

Neither of these is true for Mozilla, so the script does nothing.

As a user of the site, I would suggest you write to them and ask them to update
their script for your browser.

->Tech Evangelism

Comment 3

[Chris Lawson (gone)]

INCOMPLETE due to lack of activity since the end of 2009.

If someone is willing to investigate the issues raised in this bug to determine whether they still exist, *and* work with the site in question to fix any existing issues, please feel free to re-open and assign to yourself.

Sorry for the bugspam; filter on "NO MORE PRE-2010 TE BUGS" to remove.