Closed
Bug 221763
Opened 22 years ago
Closed 22 years ago
XPTC_InvokeByIndex crashes when cross-compiled under GCC 3.x for target arm-linux
Categories
(Core :: XPCOM, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.6alpha
People
(Reporter: darin.moz, Assigned: darin.moz)
Details
(Whiteboard: [minimo])
Attachments
(1 file)
|
1008 bytes,
patch
|
timeless
:
review+
shaver
:
superreview+
|
Details | Diff | Splinter Review |
XPTC_InvokeByIndex crashes when cross-compiled under GCC 3.x for target arm-linux.
I have a patch which fixes this.
|
Assignee | |
Updated•22 years ago
|
Severity: normal → critical
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [minimo]
Target Milestone: --- → mozilla1.6alpha
|
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #132980 -
Flags: review?(BradleyJunk)
|
|
Assignee | |
Comment 2•22 years ago
|
||
so, the existing code just happens to work when compiled using GCC 2.95 ... i
think it magically chooses not to use $sp for other things. GCC 3.3.1 on the
other hand decides to make use of $sp to reference some stuff, and that makes
things go to hell in a hurry. the fix is simple: tell GCC that we are using $sp
for specific things. as a result GCC uses $r5 instead, and things are happy :)
Comment on attachment 132980 [details] [diff] [review]
v1 patch
sp is clearly used,
this is the right thing (tm)
Attachment #132980 -
Flags: review?(BradleyJunk) → review+
|
||
Comment 4•22 years ago
|
||
Comment on attachment 132980 [details] [diff] [review]
v1 patch
Agreed!
Attachment #132980 -
Flags: superreview+
|
|
Assignee | |
Comment 5•22 years ago
|
||
fixed-on-trunk ... thx for the quick reviews guys!
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•