221879 - Ok button on Downloads preferences pane does nothing (problem with save all files to this folder option)

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[jt.marsh]

User-Agent:       / (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6a) Gecko/20031010 Firebird/0.7+
Build Identifier: / (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6a) Gecko/20031010 Firebird/0.7+

Clicking the OK button with the Downloads preference pane showing doesn't do
anything.

Reproducible: Always

Steps to Reproduce:
1.Open preferences dialog
2.click Downloads to get the download options
3.click OK

Actual Results:  
Nothing happens

Expected Results:  
Dialog should close, preferences should be accepted.

Comment 1

[Mike Connor [:mconnor]]

Works for me using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6a)
Gecko/20031011 Firebird/0.7+

Have you tested with a clean profile?  Do you have any extensions installed?  If
you check the javascript console, are there any errors? (Open the console, clear
it, open prefs to that pane, click okay, then report what appears in the JS
console, if anything).

Please also try with a clean install and profile.

Comment 2

[jt.marsh]

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]"  nsresult: "0x80004005
(NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://mozapps/content/downloads/pref-downloads.js :: updateSaveToFolder ::
line 177"  data: no]

With a new profile it works fine until I check the "Save all files to this
folder" option.

Comment 3

[Jonathan Louie]

confirmed, with always save to desktop.  works fine on ask me every time.

Comment 4

[Wayne Woods]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6a) Gecko/20031016
Firebird/0.7+
Yeah, only seems to fail if the Desktop Folder is selected. If you select any
other folder, it'll close fine. The "Show Folder" button also fails to do
anything if the Desktop Folder is selected.

There seems to be an easy temp. workaround. Select "Other..." from the folder
list, and then highlight your desktop from the selection pane. That seems to get
it working.

Maybe the "Desktop Folder" option simply isn't associated with a real folder path?

Comment 5

[Mike Connor [:mconnor]]

*** Bug 222986 has been marked as a duplicate of this bug. ***

Comment 6

[Fred Trinkoff]

*** Bug 223042 has been marked as a duplicate of this bug. ***

Comment 7

[Fred Trinkoff]

I want to confirm all the details of this bug in the 0.7 branch release. 

It seems to be that Desktop isn't associated with the real path, cause as soon
as I browse and actually select the Desktop, it's fine. When it's set-up the
original way, once I hit the Downloads pane of the Preferences panel, it won't
close with OK, only with 'Cancel.' This is true even if I then move to another
pane. It still won't close once I have viewed downloads, as long as the "Save
all files to this folder" option is set to "Desktop."

Comment 8

[HARUNAGA Hirotoshi]

WFM on 20031024/Mac.

Comment 9

[Wayne Woods]

WFM too. It was still broken on 20031023, but fixed on 20031024.

Comment 10

[Mike Connor [:mconnor]]

.

Comment 11

[Mike Connor [:mconnor]]

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/toolkit/mozapps/downloads/content&command=DIFF_FRAMESET&file=pref-downloads.js&rev1=1.3&rev2=1.4&root=/cvsroot

I think Macolytes have a new god now

Comment 12

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change