221984 - [PATCH] Camino builds are busted.

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Ludovic Hirlimann [:Usul]]

Cls' tinderbox is busted as is simon b wooside's.

Simon found a workaround which is to :
"I just had to add ../dist/include/necko to the header search path for 
PrivacyPrefPane target in the project on my build. It couldn't find 
nsCCookieManager.h ... Seems to be due to:

http://bugzilla.mozilla.org/show_bug.cgi?id=210561

I don't know how the tinderbox is building OK without this project file 
change.....???
"

Comment 1

[Ludovic Hirlimann [:Usul]]

adding interested parties to cc.

Comment 2

[cls]

The tinderbox wasn't deleting camino/build since I thought camino had
dependencies set up properly.  I guess not.

Comment 3

[S Woodside]

Attachment: add necko to HEADER_SEARCH_PATHS

A patch to project.pbproj. The line numbers may be off, I deleted other hunks
that had nothing to do with the fix.

Comment 4

[S Woodside]

Comment on attachment 133234 [details] [diff] [review]
add necko to HEADER_SEARCH_PATHS

that's HEADER_SEARCH_PATHS

Comment 5

[Ludovic Hirlimann [:Usul]]

adjusting summary.
Simon you should ask someone to review you patch so we could land it.

Comment 6

[S Woodside]

Comment on attachment 133234 [details] [diff] [review]
add necko to HEADER_SEARCH_PATHS

good idea...

Comment 7

[Mike Pinkerton (not reading bugmail)]

landed

Comment 8

[Ludovic Hirlimann [:Usul]]

.

Comment 9

[S Woodside]

Comment on attachment 133234 [details] [diff] [review]
add necko to HEADER_SEARCH_PATHS

setting sr+ to get this off the list (this list:
http://bugzilla.mozilla.org/request.cgi?action=queue&requester=&product=Camino&
type=all&requestee=&component=&group=type   )