Closed Bug 221988 Opened 21 years ago Closed 21 years ago

Kill doesQI

Categories

(Other Applications :: DOM Inspector, defect)

Product:
Other Applications
Component:
DOM Inspector
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: neil, Unassigned)

References

Details

Attachments

(2 files)

Proposed patch
6.24 KB, patch
peterv
: review+
alecf
: superreview+
Details | Diff | Splinter Review
Simplified version using fix for bug 162927
5.96 KB, patch
Details | Diff | Splinter Review 
doesQI is a very bad implementation of instanceof. Die, I say, Die!
Attached patch Proposed patch — — Splinter Review 

    
  

        Attachment #133178 -
        Flags: superreview?(alecf)

        Attachment #133178 -
        Flags: review?(caillon)

    
    

    
  
I'm not sure that we can do this just yet since |instanceof| doesn't necessarily
always work the way it is supposed to.  See bug 162927 comment 8 for one example.

    
    

    
  
Although I suppose in the cases that it was used for, it probably should work....

    
    

    
  
OK, so it looks like instanceof Element isn't very useful, but instanceof
Components.interfaces.nsIDOMElement works as expected.

    
    

    
  
Comment on attachment 133178 [details] [diff] [review]
Proposed patch

neat. sr=alecf

        Attachment #133178 -
        Flags: superreview?(alecf) → superreview+

    
    

    
  
Comment on attachment 133178 [details] [diff] [review]
Proposed patch

Ok then, moa=caillon but please get peterv or jst to sign off on this patch.

    
  

        Attachment #133178 -
        Flags: review?(caillon) → review?(peterv)

    
    

    
  
Fixing bug 162927 will shorten this patch.
Depends on: 162927

        Attachment #133178 -
        Flags: review?(peterv) → review+

    
    

    
  
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Core → Other Applications

    
  
Assignee: dom-inspector → nobody
QA Contact: timeless → dom-inspector

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: