Status

RESOLVED FIXED
15 years ago
11 years ago

People

(Reporter: neil, Unassigned)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

15 years ago
doesQI is a very bad implementation of instanceof. Die, I say, Die!
(Reporter)

Comment 1

15 years ago
Created attachment 133178 [details] [diff] [review]
Proposed patch
(Reporter)

Updated

15 years ago
Attachment #133178 - Flags: superreview?(alecf)
Attachment #133178 - Flags: review?(caillon)
I'm not sure that we can do this just yet since |instanceof| doesn't necessarily
always work the way it is supposed to.  See bug 162927 comment 8 for one example.
Although I suppose in the cases that it was used for, it probably should work....
(Reporter)

Comment 4

15 years ago
OK, so it looks like instanceof Element isn't very useful, but instanceof
Components.interfaces.nsIDOMElement works as expected.

Comment 5

15 years ago
Comment on attachment 133178 [details] [diff] [review]
Proposed patch

neat. sr=alecf
Attachment #133178 - Flags: superreview?(alecf) → superreview+
Comment on attachment 133178 [details] [diff] [review]
Proposed patch

Ok then, moa=caillon but please get peterv or jst to sign off on this patch.
(Reporter)

Updated

15 years ago
Attachment #133178 - Flags: review?(caillon) → review?(peterv)
(Reporter)

Comment 7

15 years ago
Fixing bug 162927 will shorten this patch.
Depends on: 162927
(Reporter)

Comment 8

15 years ago
Created attachment 133260 [details] [diff] [review]
Simplified version using fix for bug 162927
Attachment #133178 - Flags: review?(peterv) → review+
(Reporter)

Comment 9

15 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: Core → Other Applications
Assignee: dom-inspector → nobody
QA Contact: timeless → dom-inspector
You need to log in before you can comment on or make changes to this bug.