22225 - Auto-insert of <br> in empty cell inserts 2 <br> when file is read

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Charles Manske]

The rules code enforces non-empty cells by inserting a <br> when a table cell
is created. But when we read in a table that has completely empty cells, we
automatically insert 2 of them instead of just 1.
Now that I think about it, I'm not sure if we should be inserting any <br>
during file loading. That kind of HTML mangling is what got us much criticism
in earlier versions.

Comment 1

[Charles Manske]

Attachment: A table with an emtpy cell for testing editor loading

Comment 2

[Charles Manske]

Note that if the test file is loaded in the browser, only the first cell (with
the "1") shows its border. There is a second cell under it that doesn't display
the border.
When you load the file into Composer, 2 <br>s are inserted into the second cell.

Comment 3

[Akkana Peck]

Agreed that we shouldn't mangle the user's html by inserting br's into table
cells.  Though this doesn't seem to be happening for me -- see the test case in
bug 22227.

Comment 4

[rubydoo123]

setting to m13

Comment 5

[Joe Francis]

hmm.  For mail compose we _do_ want to put in the breaks (we dont care about html
preservation for mail compose - we do care about being able to click in empty
cells).
But the part about getting *2* breaks is definitely a bug.

Comment 6

[Joe Francis]

fixed

Comment 7

[sujay]

verified in 1/13 build.