222342 - Speed up txStylesheet::isStripSpaceAllowed

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We can make txStylesheet::isStripSpaceAllowed faster for the (vastly common)
case when there are no xsl:strip-space or xsl:preserve-space elements in the
stylesheet. Right now txStylesheet::isStripSpaceAllowed has a fairly suboptimal
route when called on a textnode, including getting the nodevalue and checking if
the its whitespace data.

patch comming up

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to fix

This simply earlyreturns if we have no stripspace rules

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

btw, I should mention that this patch was made possible by the landing of bug
199613, since before that we relied on txStylesheet::isStripSpaceAllowed to
strip textnodes in the root of the document.

Comment 3

[Axel Hecht]

Comment on attachment 133363 [details] [diff] [review]
patch to fix

oops, what happened? ;-)

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch v2

this makes us return false for document-nodes. It won't make a difference since
documents will never contain any textnodes, but this way we'll save the
nodetype check in the code for //.

http://lxr.mozilla.org/mozilla/source/extensions/transformiix/source/xpath/PathExpr.cpp#187

Comment 5

[Peter Van der Beken [:peterv]]

I suppose you'll hold off until bug 56764 is fixed?

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in, thanks for reviews