222442 - Modifying a couple of scripts to enable building with Intel 8.0 C/C++ compiler

Status: RESOLVED WONTFIX

(Firefox Build System :: General, enhancement)

Description

[Steve Williams]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1)
Build Identifier: Trunk

Mozilla cannot currently be compiled using the Intel 8.0 C/C++ compiler 
because the build rejects the compiler.

Reproducible: Always

Steps to Reproduce:
Install the Intel 8.0 C/C++ compiler, create a Mozilla build configuration 
script containing the following :-

CC=icl
CXX=icl
CPP=icl
LD=xilink

make -f client.mk build_all from the root of the tree.
Actual Results:  
The build system complains that the compiler is not supported & exits.

Expected Results:  
The build should proceed as this compiler is capable of building the entire 
mozilla tree.

You can verify that this compiler is capable of building the entire tree by 
making the following minor script modifications.

1) Hack mozilla\configure (around line 2637):

if test "$_CC_MAJOR_VERSION" = "12"; then
_CC_SUITE=6
elif test "$_CC_MAJOR_VERSION" = "13"; then
_CC_SUITE=7
else
_CC_SUITE=6
fi


2) Hack mozilla\configure.in (around line 345)


if test "$_CC_MAJOR_VERSION" = "12"; then
_CC_SUITE=6
elif test "$_CC_MAJOR_VERSION" = "13"; then
_CC_SUITE=7
else
_CC_SUITE=6
fi

Then perform a make -f client.mk build_all . This should succeed & the 
resultant binary seems (with very limited testing) stable.


I propose checking in the configure script changes above as the only side 
effect this will have is to prevent a warning if you are running another 
unsupported compiler. Obviously, if someone wants to do the work to explicitly 
check for the compiler & react accordingly in the makefiles, this would be a 
better solution.

For those who are interested, you can get the latest beta of Intel's v.8.0 
C/C++ compiler from 
http://www.intel.com/software/products/compilers/beta/register.htm

Comment 1

[Boris Zbarsky [:bzbarsky]]

You may want to attach the changes as a "diff -u8" and request review on it...

Comment 2

[Ali Ebrahim]

How is this related to bug 81087? Is it a dupe?

Comment 3

[Steve Williams]

(In reply to comment #2)
> How is this related to bug 81087? Is it a dupe?

81087 refers to Intel's Linux compiler, and issues that used to prevent 
compilation with Intel's 7.1 compiler (now a legacy product). I filed a bug 
report with Intel & the compilation problems I found were resolved in 8.0. I 
have not had time to close this issue - i.e. get 8.0 compilation on win32 
recognized & built by the trunk, due to time constraints, but recommend that 
support is integrated as this compiler is worth supporting. If anyone has time 
to wrap this one up, it would be worth doing. Sorry I can't be more helpful at 
the moment.

- Steve.

Comment 4

[Benjamin Smedberg]

Patches welcome, I'll be happy to review.

Comment 5

[Jevin Sweval]

I have tried this on the latest CVS checkout and it does not work. Any ideas?

Comment 6

[Jevin Sweval]

(In reply to comment #5)
> I have tried this on the latest CVS checkout and it does not work. Any ideas?

Still doesn't work. It would be nice to build with ICC to see if one could eek
any more performance out of some functions that people aren't willing to optimize!

Comment 7

[Mike Hommey [:glandium]]

Intel C Compiler was supported at some point in the past, but that hasn't been the case for many years. As of now, the only supported compilers are GCC and clang/clang-cl. We are not looking into supporting other compilers.