22250 - Reproducable Mozilla crash when clicking on a directory

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P1)

Description

[Mo DeJong]

I got this crash on my RedHat 5.2 system. This was from the CVS Dec 20th.

Make these directories.


mkdir /tmp/test
touch /tmp/test/f1
touch /tmp/test/f2

mkdir /tmp/test/one
mkdir /tmp/test/one/onesub
touch /tmp/test/one/onesub/f1
touch /tmp/test/one/onesub/f2

mkdir /tmp/test/two
mkdir /tmp/test/two/twosub
touch /tmp/test/two/twosub/f1
touch /tmp/test/two/twosub/f2



Now type file:///tmp/test into the browser window. This should open up the
root window and display the files and directories like this.

--------
   f1
   f2
>  one
>  two
--------

Now click on the > to the left of the directory "one"
to expand the contents of the directory.

After doing that the following should be displayed.

--------
   f1
   f2
\/  one
    > onesub
>  two
--------

Now click on the > to the left of the directory "onesub"
to expand the contents of the directory.

After doing that the contents of onesub should be displayed
but the browser seems to close the "onesub" and "one" directories
in the tree. The incorrect listing looks like this.

--------
   f1
   f2
\/  one
>  two
--------

You can now crash mozilla by clicking on the \/ widget to the
left of the "one" directory.

The crash seems to be happinging in seemingly random locations.
I have reproduced this error a number of times and the crash
does not seem to happend in the same place twice.

Comment 1

[Eli Goldberg]

I'm going to guess that this may be a problem with the widget itself, and sending
the bug over to trudelle for consideration.

dejong, thanks for the beautiful bug report!

Comment 2

[Peter Trudelle]

assigning to hyatt as p1 for m13

Comment 3

[David Hyatt]

This seems to be the same as the insidious bug in CalculateRowHeights.
Is this actually still happening, or are you using older bits?

Comment 4

[David Hyatt]

No comment given.  I'm assuming this is a dup of the problem I fixed.  Closing
out.

Comment 5

[Mo DeJong]

Hi all.

This is a ammendment to the original bug report. The crashing problem
was fixed, but there is another problem that seems to be directly related.
If I should open another bug for this problem please tell me.

When a directory name is double clicked, it will not display the
file contents until the actual > widget is clicked to expand the
entry. This is not the correct thing to do.


1. type file:///tmp/test into the browser window. This should open
up the root window and display the files and directories like this.

--------
   f1
   f2
>  one
>  two
--------


Now double click on the directory "one" (NOT the > widget to
the left of the text "one"). You should see the following
result.

--------
   f1
   f2
\/  one
>  two
--------

Double click "one" again to return it to the original state.
Now click on the > widget to the left of the text "one".
The following should be displayed.

--------
   f1
   f2
\/  one
    > onesub
>  two
--------

Click on the > widget to return it to the original state.
Now if you double click on the text "one", it will open
the directory just like a click on the > widget. The
bug here is that a double click on the text should have
displayed the contents of the subdirectory, it does not.
I should not have to click on the > widget to get a
double click on the text "one" to work.

Comment 6

[Claudius Gayle]

dejong, what you describe needs to be it's own seperate bug. I would cut and paste what
you already wrote into a new bug - including the info on setting up the test directories. I
believe the component for the new bug would be xptoolkit.

Comment 7

[Mo DeJong]

Ok, I opened up a new bug for the second "double click" problem. I am going
to mark this bug as verified because I checked it and it seems to work
just fine. The new bug number is 23654 in case anyone wanted to know.

Comment 8

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/3eaf80a62de3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22250 - Convert Recent Bookmarks to Jetpack Compose