222542 - delayed profile install fails

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P2)

Description

[Karsten Düsterloh]

The installed-chrome.txt mechanism ("delayed chrome") in nsChromeRegistry
(CheckForNewChrome, ProcessNewChromeBufferns) is meant to be able to install
into the user profile - but it isn't.

If you have a line like this in your installed-chrome.txt:

content,profile,url,jar:file:///E:/kddev/kk4zd57d.slt/chrome/mess.jar!/content/mess/

the respective package won't be installed and hence not show up in chrome.rdf or
overlayinfo in the profile's chrome directory.

Reason:
WriteInfoToDataSource::1690 tries to get a datasource for a
overlayinfo/<somewhere>/overlays.rdf needed by the new package, hence calling
GetDynamicDataSource. This in turn should load the datasource via LoadDataSource
(with aProfilePath=nsnull), but can't:

LoadDataSource::1265
  // Try the profile root first.
  if (aUseProfileDir) {
    // use given profile path if non-null
    if (aProfilePath) {
      key = aProfilePath;
      key += "chrome/";
    }
    else
      key = mProfileRoot;

    key += aFileName;
  }
  else {
    key = mInstallRoot;
    key += aFileName;
  }

mInstallRoot is always initialized at the beginning of CheckForNewChrome, but
mProfileRoot has never been initialized! And without the profile chrome path, no
overlay info can be computed.

I can see two possible solutions:
1) Always initialize mProfileRoot when initializing mInstallRoot (at the
beginning of CheckForNewChrome)
2) Stall the initialization of mProfileRoot until we're sure we have to deal
with a delayed profile chrome (in ProcessNewChromeBuffer)

Since delayed profile installations are quite rare, I'll provide a (very simple,
actually) patch for #2.

Comment 1

[Karsten Düsterloh]

Attachment: init mProfileRoot if it's needed

Init mProfileRoot in ProcessNewChromeBuffer as soon as it's clear that we may
need it

Comment 2

[Benjamin Smedberg]

Comment on attachment 133463 [details] [diff] [review]
init mProfileRoot if it's needed

I will get to reviewing this soon.

Comment 3

[Benjamin Smedberg]

Comment on attachment 133463 [details] [diff] [review]
init mProfileRoot if it's needed

Looks good.

Comment 4

[Alec Flett]

Comment on attachment 133463 [details] [diff] [review]
init mProfileRoot if it's needed

sr=alecf

Comment 5

[timeless]

checked in

Comment 6

[Benjamin Smedberg]

.