222667 - Composition inserts three blank lines between headers and message

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jerry Baker]

2003101604 trunk

Compose a plain-text message and send it. Notice that there are three blank
lines between the headers and the message instead of one blank line. This
regressed between 2003101504 and 2003101604 builds.

Comment 1

[Stefan Borggraefe]

This also happens on Linux.

Comment 2

[Christian Eyrich]

And one blank line after the body itself too ...

Comment 3

[Frank Wein [:mcsmurf]]

sicking: it seems your checkin from Bug 199613 broke this, backin out your patch
made this work again.

Comment 4

[Frank Wein [:mcsmurf]]

sicking: um i just tried again, backed out again but now the bug is still there.
But anyway might you try to back your patch out if you have then the problem is
gone (sorry, if i waste your time with this...) ? 

Comment 5

[Christian Eyrich]

Frank, I'm sure it's bug 199613's patch. Each time when removing it, the problem
disappears and when reapplying the patch it's back again.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

i'll take a look at this, the regression is most likly due to my change to the
serializer

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This is a pretty bad regression since it inserts two empty lines at the top of
every mail that is sent (and an additional two if you save a draft first and
then send it).

I should have a patch pretty soon

Comment 8

[Christian Eyrich]

*** Bug 223133 has been marked as a duplicate of this bug. ***

Comment 9

[Asa Dotzler [:asa]]

1.6a doesn't have much time. Jonas, do you think you could have something in the
next day or two?

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yes, i should have a patch tomorrow latest, it's almost done.

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to fix

This moves the logic to add newlines from the encoder to the serializer. The
problem was that we appended newline characters for root domnodes when using
the plaintext serializer which we of course shouldn't do.

It also makes us not add newlines after the last root node, or when serializing
just one rootnode.

Comment 12

[Christian Eyrich]

*** Bug 223306 has been marked as a duplicate of this bug. ***

Comment 13

[Peter Van der Beken [:peterv]]

Comment on attachment 133897 [details] [diff] [review]
patch to fix

> Index: content/base/src/nsXMLContentSerializer.h
> ===================================================================

> +  void MaybeAddInrootNewline(nsAString& aStr);
> +  void MaybeFlagInrootNewline(nsIDOMNode* aNode);

I'd name this MaybeAddNewLineInRoot and FlagMaybeAddNewLineInRoot or something
like that.

>    PRInt32 mPrefixIndex;
>    nsVoidArray mNameSpaceStack;
> -  PRBool mInAttribute;
> +  PRPackedBool mInAttribute;
> +  PRPackedBool mAddInrootNewline;

mAddNewLineInRoot

Comment 14

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

talked on irc and we decided to go for MaybeAddNewline, MaybeFlagNewline and
mAddNewline.

Comment 15

[Johnny Stenback (:jst)]

Comment on attachment 133897 [details] [diff] [review]
patch to fix

sr=jst

Comment 16

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 133897 [details] [diff] [review]
patch to fix

This fixes a regression in mail where two (or more) blank lines would be
inserted at the start of a mail before it's being sent.

The patch is not 100% safe, but should not break anything that isn't already
broken.

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 133897 [details] [diff] [review]
patch to fix

a=asa (on behalf of drivers) for checkin to 1.6alpha

Comment 18

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in, thanks for reviews

Comment 19

[Hermann Schwab]

wfm Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031024
Sent a testmail from my POP Account at one provider to my IMAP account of
another provider, plaintext, was looking fine, and I opened the editor,
source-view, and found only one <br> between header and subject, and after my
'greetings hh' at the end. Shouldn´t this bug be marked fixed?

Comment 20

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

upps, thought i did that already, thanks