Closed
Bug 222901
Opened 21 years ago
Closed 20 years ago
white lines in image on first load
Categories
(Core :: Layout: Images, Video, and HTML Frames, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
References
()
Details
(Keywords: fixed-aviary1.0, fixed1.7.5)
Attachments
(4 files, 1 obsolete file)
51.09 KB,
image/png
|
Details | |
249 bytes,
text/html
|
Details | |
2.63 KB,
text/plain
|
Details | |
3.98 KB,
patch
|
tor
:
superreview+
mkaply
:
approval1.7.5+
|
Details | Diff | Splinter Review |
When the firebird start page first loads (or shift+reload), I see two white
lines in the screen shot image on the right. I'm just guessing by putting this
in Image: Layout; I'm sure it'll turn out to be some insane twip rounding bug.
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Comment 2•21 years ago
|
||
Here are things I found are critical to triggering the bug:
- the transitional doctype, presumably to trigger quirks mode
- the h3 text above the image
- the height on the image (causing it to be scaled)
- the image loading from the server (presumably to slow down the image load so
that we don't draw all of it at once)
any ideas?
Assignee | ||
Comment 3•21 years ago
|
||
This is from enabling TRACE_IMAGE_ALLOCATION in nsImageGTK.cpp. (I'm still
trying to understand why the destination y coordinate is an increasing negative
number)
Assignee | ||
Comment 4•21 years ago
|
||
This should make things better. The problem is that when we get new decoded
rows in the source image, we don't necessarily invalidate as many rows onscreen
as we need to (for scaled images). This patch makes us invalidate from (N-1 *
F) to (N+1 * F) when row N is received (F is the scaling factor). tor tells me
this is a mathematical bound on the nearest-neighbor scaling function used in
XlibRectStretch (nsImageGTK.cpp), so it should cover any row that could
possibly be drawn using the newly-decoded source row. I tested this and didn't
find any Tp regressions.
Assignee | ||
Updated•21 years ago
|
Attachment #156072 -
Flags: superreview?(tor)
Attachment #156072 -
Flags: review?(pavlov)
Updated•20 years ago
|
Attachment #156072 -
Flags: review?(pavlov) → review+
Assignee | ||
Comment 5•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #156072 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #157167 -
Flags: superreview?(tor)
Attachment #157167 -
Flags: superreview?(tor) → superreview+
Assignee | ||
Updated•20 years ago
|
Attachment #156072 -
Flags: superreview?(tor)
Assignee | ||
Comment 6•20 years ago
|
||
Comment on attachment 157167 [details] [diff] [review]
merged to the trunk
requesting 1.7 branch approval
Attachment #157167 -
Flags: approval1.7.3?
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Flags: blocking-aviary1.0+
Comment 7•20 years ago
|
||
Comment on attachment 157167 [details] [diff] [review]
merged to the trunk
a=mkaply
Attachment #157167 -
Flags: approval1.7.x? → approval1.7.x+
Assignee | ||
Comment 8•20 years ago
|
||
checked in on aviary branch and 1.7 branch
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0,
fixed1.7
Resolution: --- → FIXED
Assignee | ||
Comment 9•20 years ago
|
||
should have been fixed1.7.x, not fixed1.7
Keywords: fixed1.7 → fixed1.7.x
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•