222940 - Offline & Diskspace and Server Setting panes are too large in Account Manager

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Jacek Piskozub]

Bug 89202 made Account Settings window non-resizable. The problem is it is too
small too show Local Directory window - and therefore to be able to change the
field.

Comment 1

[Jacek Piskozub]

Attachment: The Account Setting window crippled by bug 89212 fix.

This is how it looks on both my Windows ME computers (fresh trunk build).

Comment 2

[Jacek Piskozub]

Adding the guilty parties to CC: so they can see what they did ;-)

Comment 3

[Frederic Bezies]

Adding myself, because this bugfix (for 89212) is also guilty for killing
Thunderbird start in today's build (see bug 222841)

Comment 4

[Jacek Piskozub]

Comment #0 should say 
"Bug 89212 made Account Settings window non-resizable."
Sorry.

Comment 5

[Stefan Borggraefe]

Jacek: What settings do you use for your font size? What is your DPI setting in
Windows?

I can only reproduce this when I set my Windows DPI setting to 72 dpi. This is
on Windows 2000. With this setting also the main Preferences dialog
(Edit|Preferences...) is much to small. I think this is because the window size
of these two windows is scaled relative to the font size, but not all of their
content is, e.g. some margins and widgets have a fixed pixel size. Thus with
very small fonts the windows are to small for their content.

Taking bug.

Comment 6

[Jacek Piskozub]

96 DPI
Proportional: Serif 16
Monospace: Courier New: 13

Don't you think it should work with _any_ font settings?

Comment 7

[[e-mail]]

I see this straight away... unfortunately I forgot to preview this window with a
POP account, I only have IMAP accounts.

Comment 8

[Jacek Piskozub]

It's better with the Classic theme (only a few pixels too small), worse with Modern.

Comment 9

[Jacek Piskozub]

Attachment: Patch, version 1.0

One more "em" makes it OK for me. I'm not 100% sure that it is enough for any
font settings/OS combination.

Comment 10

[Stefan Borggraefe]

Jacek: Of course this should work with any font size. I just wanted to collect
some information in order to fix this.

Comment 11

[[e-mail]]

Comment on attachment 133682 [details] [diff] [review]
Patch, version 1.0

I don't think increasing the height is the best way to fix this problem.

Comment 12

[[e-mail]]

Comment on attachment 133682 [details] [diff] [review]
Patch, version 1.0

Silly bugzilla :-(

Comment 13

[Stefan Borggraefe]

Attachment: Saves space by rephrasing

The problem that causes this bug is that the word "Inbox" is wrapped to the
next line with some display configurations. There are two possible ways to fix
this:

1. Make the dialog larger.
2. Rephrase the option to make it shorter.

Since this string is the only string that creates the need for a larger dialog
and the point of bug 89202 was to limit the size of the dialog in order to
avoid overly complex and crowded panels, I think it is better to choose the
second way.

So the attached patch changes the UI to:

[X] Leave messages on server
    [X] For [NN] days
    [X] Until I delete or move them from Inbox

The patch also fixes a small bug where the label "days" is not disabled when
"Leave messages on server" is not checked.

Comment 14

[Christian Eyrich]

Attachment: NNTP Offline & Disk Space

Panel far to small.
Using Windows with big fonts, screen resolution 110dpi.

Comment 15

[Christian Eyrich]

Your rephrasing is more a workaround, no fix. Shouldn't the window automatically
detect what size is needed to hold the biggest pane? Otherwise if one adds a new
checkbox to e.g. POP Server Settings he'd have to change the size by hand again.

And a second point is your proposed wording. It's not really nice - if one check
both options this would be "Leave messages on server for N days and until I
delete or move them from Inbox". This reads like a paradox.

I'd prefer something like
  [X] Leave messages on server
      [X] Until I delete or move them from Inbox
      [X] But at most for [NN] days

Comment 16

[[e-mail]]

Comment on attachment 133713 [details] [diff] [review]
Saves space by rephrasing

Neat. Nice catch on the days label.

Comment 17

[[e-mail]]

Unfortunately the time taken to calculate the size of all the panes would make
the account manager unbearably slow.

Comment 18

[[e-mail]]

Comment on attachment 133713 [details] [diff] [review]
Saves space by rephrasing

How about "For at most [] days."?
[perhaps the daysEnd disable should go after the textbox disable]

Comment 19

[David :Bienvenu]

I can live with "For at most [] days." I agree with Christian that the
previously proposed wording was confusing.

Comment 20

[Stefan Borggraefe]

Attachment: NNTP Offline & Diskspace: what I currently see

This is how this dialog looks when I use Christan's settings (110dpi, Big
fonts). My screenshot is from a fresh profile. I only create some dummy
accounts and changed the theme to modern. Interessting enough the font size is
different in both screenshots. Since the dialog's size is specified in em, I
counted the width of an m in pixel on both screenshots. Christan's m has a
width of 9 pixel, mine is 13 pixel wide. This would explain why the dialog is
bigger for me than for Christian.

I get similar results on two machines with Windows 2000 SP4 and
WindowsXP SP1. I tried several different DPI settings and font
sizes. I also tried gigantic fonts by manipulating userChrome.css. The
dialog is always big enough. (Except when I use 72 dpi. But with this
setting many dialogs in Mozilla are much to small.)

Has anyone an idea how these different results can happen? I really
want to reproduce this bug, because this would make it much easier to
fix for me.

Comment 21

[[e-mail]]

Attachment: NNTP Offline & Disk Space

Display: Windows 2000 Terminal Services 800x600x8bit (thus the awful colour)
Font: Microsoft Sans Serif, 8

Comment 22

[Christian Eyrich]

Intersting.
I'm on Win98 (if that matters). Font: Microsoft Sans Serif, 8.
With Small Fonts (Kleine Schriftarten) selected (Windows says normal Size (96
dpi), I get the same result like Neil.

With Big Fonts (Große Schriftarten) selected (Windows says normal Size (120
dpi), I get what I posted.
But I get what Stefans screenshot shows if I switch to Microsoft Sans Serif, 10
as screen font. Using Microsoft Sans Serif, 10 with Small Fonts (96 dpi), the
panels fits the window too.

The 110 dpi I wrote about is what Mozilla shows as Display resolution after
using the Calibrate Resolution dialog.

So, the window is to small anyways if using Microsoft Sans Serif, 8. But it's
getting worse when switching to Big Fonts.

Comment 23

[Jacek Piskozub]

I hope we don't ship mozilla1.6b with this abomination ;-)

Comment 24

[David :Bienvenu]

can we check in the partial fix with the slightly re-worded version of Ian's
patch? sr=bienvenu with the change "For at most [] days" change.

Comment 25

[Asa Dotzler [:asa]]

I don't think we'd block an _alpha_ release for this problem so I'm setting the
blocking1.6a- flag. If a fix lands today (before the freeze) that'd be great. If
not, I'm sure drivers would consider approving a fully reviewed patch during the
freeze. 

Comment 26

[[e-mail]]

Checked in an interim patch based on attachment 133713 [details] [diff] [review] but with change as
requested by bienvenu.

Comment 27

[Jacek Piskozub]

Yes, _alpha_, not _beta_. Of, course. Sorry. And, thanks for the patch!

Comment 28

[Stefan Borggraefe]

Attachment: More space saving ideas

The checked in patch isn't enough to fix this bug. With some configurations the
POP3-Server Settings pane still doesn't fit. Also the NNTP "Offline &
Diskspace" pane is to large.

This patch ports the SMTP-server UI for entering the server port to the other
server types. Since now the "Port:" textfield is on the same line as the server
name this saves more vertical space in the server setting pane. Note: there is
a bug for changing the SMTP-server UI again (bug 220818), but the discussion
there isn't finalized yet.

Furthermore the patch removes a separator between the dialog's content and the
dialog buttons. The Preferences window has none at this position, too.

Third, to make the "Offline & Diskspace" page fit, I rephrased some more
strings to gain width and modified the separators on this page to gain height.
Especially I eliminated the phrase "message bodies" from the Diskspace
settings. I think the term "Download" already implies that the whole message is
transferred. Are these changes are acceptable?

The obvious easy alternative is to increase the dialog's size. But since it
already is huge, I'm trying to avoid this. Also one patch which does this
already has a r-. ;-)

Comment 29

[Stefan Borggraefe]

Attachment: More space saving ideas

The checked in patch isn't enough to fix this bug. With some configurations the
POP3-Server Settings pane still doesn't fit. Also the NNTP "Offline &
Diskspace" pane is to large.

This patch ports the SMTP-server UI for entering the server port to the other
server types. Since now the "Port:" textfield is on the same line as the server
name this saves more vertical space in the server setting pane. Note: there is
a bug for changing the SMTP-server UI again (bug 220818), but the discussion
there isn't finalized yet.

Furthermore the patch removes a separator between the dialog's content and the
dialog buttons. The Preferences window has none at this position, too.

Third, to make the "Offline & Diskspace" page fit, I rephrased some more
strings to gain width and modified the separators on this page to gain height.
Especially I eliminated the phrase "message bodies" from the Diskspace
settings. I think the term "Download" already implies that the whole message is
transferred. Are these changes are acceptable?

The obvious easy alternative is to increase the dialog's size. But since it
already is huge, I'm trying to avoid this. Also one patch which does this
already has a r-. ;-)

Comment 30

[Stefan Borggraefe]

Comment on attachment 133859 [details] [diff] [review]
More space saving ideas

Oops, I submitted this twice by accident. Sorry for the spam.

Comment 31

[timeless]

i was asked... oh well...

for offline (this is based on looking at offline news, but the idea should apply
to the others)

1. the descriptive paragraph in offline should be removed. the select button
could have 3-5 words which has the same meaning as whatever that long unreadable
text had (without the {click the button} bit). after using the button i realized
that it's not a per server item, so it shouldn't be stuck at the server level.
Yes that means that it'll feel very lonely if it remains in account settings,
i'm sorry.

It turns out that the offline dialog which this select button is tied to can be
reached from the file menu already:
file>offline>download/sync now>select

2. Remove the select button from account settings entirely.
If the select button in download/sync isn't obvious then we could add it to the
file>offline> menu.

3. Remove "To save download time and disk space:"
it adds nothing, the user will supply the reasons for selecting an option.

4. I just looked at the first set of check boxes
Download message bodies for messages since (sic?) [30 ] days ago
Replace then entire section described by 3 with:

Do not download:
[ ] Read messages
[ ] Messages larger than [50 ] KB
[ ] Messages more than [30 ] days old

If at some point one could opt not to download attachments the item would be:
[ ] Attachments or [ ] Attachments larger than [50 ] KB

5. change "When it is time to clean up messages:" to "When compacting folders:"
since i'm told that's what it does, there's no way a user will figure this out
<bug 223272>. Any value lost by this change should be moved into the documentation.

6. replace then entire section described by 5 with:
When compacting folders, discard:
[ ] read messages
[ ] messages that arrived more than [30 ] days ago
[ ] messages that are not among the [30 ] newest
[ ] message bodies more than [30 ] days old

Leaving all items unchecked is equivalent to the old (*) Keep all messages

If someone ever really wants to redo this, it should probably eventually become
part of a rules editor which uses an interface like filters and has a wizard
which lets peopple select the basic rules.

Comment 32

[Stefan Borggraefe]

> the select button could have 3-5 words which has the same meaning as whatever
> that long unreadable text had (without the {click the button} bit). after 
> using the button i realized that it's not a per server item, so it shouldn't 
> be stuck at the server level.

On the IMAP-Offline & Diskspace page there are two server-specific
offline-options along the "Select..."-button. I think it would be quite
irritating when you could configure such options there and then can't select the
folders which should be available when working offline. An alternative to
timeless' idea would be to make this button a little server-specific: Select the
treeitem associated with the currently configured server and expand its children.

> change "When it is time to clean up messages:" to "When compacting folders:"
> since i'm told that's what it does.

I was the one who told this. But this was only guessing not knowledge. Now I
think I was wrong actually. "When messages are removed because you get new
messages or compact folders:" would be correct here, but this is to long. I tend
to leave the current term unchanged and let the help files explain what exactly
it means.

> [ ] messages that arrived more than [30 ] days ago
> [ ] messages that are not among the [30 ] newest

Having these two checked simultaneously would require backend-changes.
Furthermore I don't really know what should happen in this situation. Which of
the both criteria has priority then?
Also turning this into two radio buttons wouldn't be sufficient, because then
the option "Keep all message" couldn't be chosen anymore. So I guess the current
three radio buttons have to stay.

I'm presently working on an "Offline & Diskspace"-page that needs less space
than the current one incorporating the other ideas from timeless and some from
myself.

Comment 33

[Stefan Borggraefe]

Attachment: Saves space on "Offline & Diskspace" and "Server settings"

This patch fixes the bug by increasing the space needs of the both biggest
panes in the Account Settings dialog and hopefully increases the qualitiy of
the UI, too.

(Note to reviewer: I removed the broadcaster bc_keepMsg, because it didn't work
when you select one of the other radio buttons first and then "All Messages"
after this.)

Comment 34

[Stefan Borggraefe]

> This patch fixes the bug by increasing the space needs...

Reducing not increasing of course. ;-)

Comment 35

[[e-mail]]

Comment on attachment 134088 [details] [diff] [review]
Saves space on "Offline & Diskspace"  and "Server settings"

OK, here are my initial impressions, just a quick scan...

>+            <textbox wsm_persist="true" size="3" id="server.port"
>+                     preftype="int" hidable="true" hidefor="movemail" 
>+                     prefstring="mail.server.%serverkey%.port"/>
>+            <label value="&serverPortDefault.label;"/>
>+            <label id="defaultPort"/>
Shouldn't these hide for movemail too?

>+        <button image="chrome://communicator/skin/icons/offline.gif" label="&offlineSelectNntp.label;" 
>+                accesskey="&offlineSelect.accesskey;" oncommand="onClickSelect()" id="selectFolderButton"/>
This is a no-no, all chrome images should be defined in theme CSS.

>+<!ENTITY nntpKeepMsg.label "Messages arrived within the past">
I'd prefer this to read "last", rather than "past".

Comment 36

[Ian Neal]

 <!ENTITY offlineNewFolder.label "When I create new folders, select them for
offline">
I think this would make more sense with "use" added after offline

+<!ENTITY nntpKeepMsg.label "Messages arrived within the past">
I agree with Neil about the "past" and "last"
I also think that you still need to keep the "which have" in between "Messages"
and "arrived"

I think that new port/default port layout reduces the amount of space for nntp
server names too much but I'm not sure there is any other way to do it.

Comment 37

[Stefan Borggraefe]

Attachment: Addressed Neil's and Ian's comments

Except the space for the server name is the same as in the last patch. I could
make it bigger when I'd remove the grid, but then the "User Name:", "Server
Name:" and "Server Type:" wouldn't be aligned anymore.

Comment 38

[Tom Sommer]

Is the "For at most" correct understandable english?

It looks strange and isn't really that clear what is ment

maybe "while they are under X days old" or "if they are under X days old"

Comment 39

[Ian Neal]

I presume you mean in the POP server settings pane:
"For at most [NN] days" does make sense if you take it with the "Leave messages
on server" above. An alternative could be "For no more than [NN] days"

Comment 40

[Ian Neal]

Just noticed that if you are using the cursor keys and tab to navigate round the
off-line settings for news servers the movement between the radio buttons is the
reverse of what you expect.

 <!ENTITY offlineNewFolder.accesskey "h">
h cannot be used here - does Help - perhaps use "W"?

+<!ENTITY nntpNotDownloadRead.label "Read messages">
+<!ENTITY nntpNotDownloadRead.accesskey "r">
change to "R" so it doesn't need to be altered when bug 68841 is fixed

+<!ENTITY nntpKeepAll.label "All messages">
 <!ENTITY nntpKeepAll.accesskey "a">
again change to uppercase for same reason as above

Look at http://www.mozilla.org/projects/ui/accessibility/accesskey.html for
reference as some of the other accesskeys might need changing to conform.

Comment 41

[[e-mail]]

Comment on attachment 134157 [details] [diff] [review]
Addressed Neil's and Ian's comments

>-    <description iscontrolcontainer="true" hidable="true" hidefor="movemail,pop3,nntp">&selectButtonDesc.label;</description>
>+    <hbox iscontrolcontainer="true" hidable="true" hidefor="movemail,pop3,nntp" align="right">
>+        <button label="&offlineSelectImap.label;" accesskey="&offlineSelect.accesskey;"
>+                oncommand="onClickSelect()" id="selectFolderButton"/>
>+    </hbox>
> 
>-    <hbox iscontrolcontainer="true" hidable="true" hidefor="movemail,pop3" align="right">
>-        <button label="&offlineSelect.label;" oncommand="onClickSelect()" id="selectFolderButton"/>
>+    <hbox iscontrolcontainer="true" hidable="true" hidefor="movemail,pop3,imap" align="right">
>+        <button label="&offlineSelectNntp.label;" accesskey="&offlineSelect.accesskey;"
>+                oncommand="onClickSelect()" id="selectFolderButton"/>
Don't duplicate ids, in this case use a class-based style instead.

>-    <separator/>
>+    <separator hidable="true" hidefor="pop3,imap,movemail"/>
>+
>     <vbox iscontrolcontainer="true" hidable="true" hidefor="movemail,pop3,imap" align="start">  
Perhaps move the separator into the box?

>+<!ENTITY doNotDownloadPop3Movemail.label "Do not download:">
>+<!ENTITY doNotDownload.label "Do not download for offline use:">
I think these should begin "To save disk space, do not ..."

+<!ENTITY nntpNotDownloadRead.label "Read messages">
+<!ENTITY nntpNotDownloadRead.accesskey "r">
Should be "R" to match "Read".

+<!ENTITY nntpKeepUnread.label "Only unread messages">
+<!ENTITY nntpKeepUnread.accesskey "O">
I think "u" might be better, as it's the first letter of a word...

+<!ENTITY nntpRemoveBody.label "Only message bodies less than">
+<!ENTITY nntpRemoveBody.accesskey "l">
... and use "O" here instead, because l is a bit narrow.

>+  margin-left: 2pt;
>+  margin-right: 2pt;
Pixels (px) please.

Comment 42

[Stefan Borggraefe]

> Just noticed that if you are using the cursor keys and tab to navigate round the
> off-line settings for news servers the movement between the radio buttons is the
> reverse of what you expect.

This seems to be a general problem with radio buttons. I see this problem with
all radio buttons in Mozilla.

Comment 43

[Stefan Borggraefe]

Attachment: Addressed Neil's and Ian's latest comments

Comment 44

[[e-mail]]

Comment on attachment 134269 [details] [diff] [review]
Addressed Neil's and Ian's latest comments

>-      <row align="center">
>+      <row align="center" flex="1">
You don't really need to change this (it seems to have no effect?)

>+
>+button.selectForOfflineUseButton {
>+  list-style-image: url("chrome://communicator/skin/icons/offline.gif");
>+}
>+
>+button.selectForOfflineUseButton > .button-box > .button-icon {
>+  margin-left: 4px;
>+  margin-right: 4px;
>+}
You know that .selectForOfflineUseButton is a button, so you don't actually
need to check that too...

Comment 45

[Stefan Borggraefe]

Attachment: Just corrects the two nits Neil found in the last patch

Otherwise unchanged.

Comment 46

[Ian Neal]

+<!ENTITY offlineNewFolder.label "When I create new folders, select them for
offline use">
+<!ENTITY offlineNewFolder.accesskey "W">
+<!ENTITY offlineNotDownload.label "Messages larger than">
+<!ENTITY offlineNotDownload.accesskey "m">
+<!ENTITY nntpKeepMsg.label "Messages which have arrived within the last">
+<!ENTITY nntpKeepMsg.accesskey "g">

2nd accesskey should really be "M" to match the case of the label
3rd one shouldn't really use letters with descenders such as "g" or "p"

One possible fix is to have is "c" for 1st and "w" for 3rd

Comment 47

[Daniel Wang]

bug 223272:
The "compact folders" menu item is disabled for newsgroups. I don't know /when/
Mozilla clean up old downloaded news messages. It could be when the user
re-sync/downlad new messages. It could be when Mail & Newsgroups is loaded. But
most users probably aren't interested in the details. That's why the label "when
it is time to clean up messages" should be changed to "Options for keeping
messages:" It's more clear and leave out unnecessary details.

+<!ENTITY nntpCleanup.label "Options for keeping messages:">
or maybe
+<!ENTITY nntpCleanup.label "Messages to keep:">

Comment 48

[Stefan Borggraefe]

> +<!ENTITY nntpCleanup.label "Messages to keep:">

I'll go with this idea, but just use "Keep:" to avoid iterating the word
"message" all too often in this setting. So when you read the pref page you get
"Keep: All messages" instead of "Messages to keep: All messages".

Comment 49

[Stefan Borggraefe]

Attachment: Some more changes

Changed nntpCleanup.label to "Keep:" and changed the access keys like Ian
suggested in comment #46.

Comment 50

[Stefan Borggraefe]

Setting a more accurate summary before this gets checked in to avoid confusion.

Comment 51

[[e-mail]]

Fix checked into the trunk, but leaving open for thunderbird changes.

Comment 52

[Stefan Borggraefe]

The Thunderbird part of the patch was checked in by David.

Marking FIXED.

Comment 53

[Max Spicer]

*** Bug 229398 has been marked as a duplicate of this bug. ***

Comment 54

[Max Spicer]

*** Bug 218026 has been marked as a duplicate of this bug. ***

Comment 55

[Jacek Piskozub]

Verifying