223151 - nsJSProtocolHandler::Suspend and ::Resume not implemented

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Looking at the code, it seems like Suspend could be implemented as |return
mStreamChannel->Suspend();| and Resume as |return mStreamChannel->Resume();|

Comment 1

[Hixie (not reading bugmail)]

(a) Why DOM HTML?
(b) Since you assigned it to a component where I'm QA, I'm curious, when would 
any code ever call these methods? :-)

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

DOM HTML because I have no idea what DOM component this should be in, and the
file is in dom/.

as for b) - this would be called usually when a user wants to pause a
download... though granted, for javascript: urls it is unlikely that a user
wants to download from them. however, it would make this channel implementation
support more of the nsIChannel api, and seems to be easily doable. that doesn't
seem like a bad thing.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

taking, I'll work on this sometime soon

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 133976 [details] [diff] [review]
patch

looks good.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsJSProtocolHandler.cpp;
/cvsroot/mozilla/dom/src/jsurl/nsJSProtocolHandler.cpp,v  <-- 
nsJSProtocolHandler.cpp
new revision: 1.100; previous revision: 1.99
done