Closed
Bug 223155
Opened 21 years ago
Closed 21 years ago
[FIXr]remove nav4algorithm code in nsStyleUtil.cpp
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.6beta
People
(Reporter: dbaron, Assigned: bzbarsky)
Details
Attachments
(1 file, 1 obsolete file)
|
13.28 KB,
patch
|
Details | Diff | Splinter Review |
I think we should remove the nav4algorithm pref code in nsStyleUtil.cpp. We shouldn't have a pref controlling things like that, and furthermore the initial reading of the pref has been broken for almost a year (since caillon's pref API checkin), as David Williams pointed out to me in email.
|
Assignee | |
Comment 1•21 years ago
|
||
Yikes. I didn't even realize we had this. Yes, we should remove this, imo.
|
|
Assignee | |
Comment 2•21 years ago
|
||
Though I'm not so sure we need the DUMP_FONT_SIZES code as it remains... what do you think, David
|
|
Assignee | |
Updated•21 years ago
|
Attachment #134145 -
Flags: superreview?(dbaron)
Attachment #134145 -
Flags: review?(dbaron)
|
Reporter | |
Comment 3•21 years ago
|
||
Comment on attachment 134145 [details] [diff] [review] Something like this may as well remove the DUMP_FONT_SIZES code.
Attachment #134145 -
Flags: superreview?(dbaron)
Attachment #134145 -
Flags: superreview+
Attachment #134145 -
Flags: review?(dbaron)
Attachment #134145 -
Flags: review+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Attachment #134145 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•21 years ago
|
||
I guess I should take this...
Assignee: dbaron → bzbarsky
Priority: -- → P2
Summary: remove nav4algorithm code in nsStyleUtil.cpp → [FIXr]remove nav4algorithm code in nsStyleUtil.cpp
Target Milestone: --- → mozilla1.6beta
|
|
Assignee | |
Comment 6•21 years ago
|
||
Patch checked in for 1.6b.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•