223176 - bookmarks manager: broken bookmark disappears

Status: RESOLVED WONTFIX

(Camino Graveyard :: Bookmarks, defect)

Description

[S Woodside]

From bug 212630, comment #69, http://bugzilla.mozilla.org/show_bug.cgi?id=212630#c69

"I've been playong with patch for the last 48 hours. I have one issue, with the
broken bookmark feature.
I added a url to the bookmark and then deleted the file from my server. It
automatically got in broken, but if i clicked on it it did not load and
disapperead from broken. Imo it should have stayed in the broken area."

Comment 1

[Alex Koralewski]

The 'broken bookmarks' feature seems to be verifying each site in your
bookmarks.  This is an innovative idea, but makes me wonder, how does one turn
this off? 

I understand it seems to query one site every 2 minutes (verified using
tcpdump), however when using a slow connection such as dial up (or with high
latency dsl/cable), it causes the browser to beachball while it tries to reach
that site.  This becomes an annoyance quickly.

This doesn't seem like a very good implementation for now (in my opinion) and
there should be a way to turn this off if chosen.  I searched the pref's file
and the preferences menu but couldn't find anything relevant.

Comment 2

[Ludovic Hirlimann [:Usul]]

actually you can't turn it off. If you're online it won't ping.

Comment 3

[S Woodside]

re comment #1 : what do you mean it "beachballs" ? Are you saying that it
completely freezes camino every two minutes?

Comment 4

[Alex Koralewski]

yes, it freezes camino for a few seconds every 2 minutes.. i probably wouldn't
notice it normally since it only pauses when i'm using my dsl connection but
when downloading something, the latency was rather high and it just beachballed
for between 5-10 seconds and wouldn't respond.  hence the request to be able to
turn it off somehow.

Comment 5

[S Woodside]

Anyway, getting back to the subject of the bug (please file a separate report
for your problem Alex).

I used to have this problem but I can't reproduce it any longer with the latest
build (my own from CVS today) . Ludovic you originally reported the problem. Can
yu still reproduce it?

Comment 6

[Ludovic Hirlimann [:Usul]]

I can repro with 20031114. Waiting 24 hours to reproduce with a cvs build.
Simon the problem I originally reported is the following :

Add a bookmark from a webserver you have access to.
Delete the file on your server. Now accessing the page will return 404.
Goto bookmarks.
The page is in the broken folder. If I double click on that particular link the
page is loaded (because of the 404, is a page).
Goto bookmark.
The dead link is no more in broken links. It will be back two days later.

I would like the broken link to stay in broken bookmarks if When i try to load
it it return 404.

Changing sev to enh.

Comment 7

[Jasper]

I can confrim the behaviour Ludo describes in Comment #6.

Comment 8

[Josh Aas]

The behavior described is a bug, not a request for new or improved
functionality. Changing severity from enhancement to normal. People's links
shouldn't disappear on them.

Comment 9

[Stuart Morgan]

This is on the list of things to fix before bookmark auto-checking is given a
GUI pref (bug 239387).

From my brief investigation, this is non-trivial to fix since the part of the
code where bookmark updating on page-load is currently tied in, we don't seem to
have access to the full server response codes.

Comment 10

[Josh Aas]

reassigning this bug to Haas since he knows this code pretty well

Comment 11

[Josh Aas]

bookmark checking code is getting ripped out so this bug is wontfix