223197 - nsCommandLineServiceMac's External Open URL methods should use browser.chromeURL

Status: RESOLVED FIXED

(Core Graveyard :: Cmd-line Features, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Currently Firebird on MacOS X cannot handle external URL open requests since the
code in the Mac command line service is hard coded to open
"chrome://navigator/content" which doesn't exist in Firebird ... it should
really check the "browser.chromeURL" pref to find out what the app's main window
URL is.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: Patch to fix

Check browser.chromeURL for the main window URL rather than using
chrome://navigator/content

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

-> me

Comment 3

[Simon Fraser [no longer active]]

Comment on attachment 133823 [details] [diff] [review]
Patch to fix

Is it worth factoring those two chunks of code? r/sr=sfraser either way

Comment 4

[Conrad Carlen (not reading bugmail)]

Comment on attachment 133823 [details] [diff] [review]
Patch to fix

yeah, if it's easy enough, some factoring would be nice. r=ccarlen anyway.

Comment 5

[timeless]

this looked wrong to me at first glance. shouldn't you use a uri dispatcher and
make sure that firebird registers to own things like http:? i don't see why apps
should have a preference for this stored anywhere near the user profile, each
native type of things should just be dispatched and be sent to the right place
by code we already have.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Ho-hum.  The uri dispatcher dispatches based on content-type.  So it would in
fact cause two uri fetches (one fetch to find out we have nothing open to handle
this type, and a second once the window opens).

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: Better Patch

This uses a separate helper method, "OpenURL" which simplifies the logic of the
two callers a bit.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 134010 [details] [diff] [review]
Better Patch

a=asa (on behalf of drivers) for checkin to the 1.5 branch and 1.6 alpha.

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed, 1.6a trunk and 1.5br.