Closed Bug 223199 Opened 21 years ago Closed 21 years ago

hostList leaks on OOM in nsPermissionManager::GetEnumerator

Categories

(Core :: Networking: Cookies, defect)

x86
Windows 2000
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

373 bzbarsky   1.19 NS_IMETHODIMP
nsPermissionManager::GetEnumerator(nsISimpleEnumerator **aEnum)
380                   const char* *hostList = new const char*[mHostCount];
388 dwitte     1.25   nsPermissionEnumerator* permissionEnum = new
nsPermissionEnumerator(&mHostTable, hostList, mHostCount, NS_CONST_CAST(const
char**, mTypeArray));
389 bzbarsky   1.19   if (!permissionEnum) {
390                     return NS_ERROR_OUT_OF_MEMORY;

hostList is leaked by 390

Found while investigating a crash nearby.
Attached patch release hostListSplinter Review
Attachment #133839 - Flags: review+
Attachment #133839 - Flags: superreview?(roc)
Attachment #133839 - Flags: superreview?(roc) → superreview+
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: