Account Settings dialog should come to front when it is already open

RESOLVED FIXED

Status

--
minor
RESOLVED FIXED
15 years ago
14 years ago

People

(Reporter: Stefan.Borggraefe, Assigned: Stefan.Borggraefe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

15 years ago
Steps to reproduce:
1. Open two MailNews windows
2. Select "Edit|Mail & Newsgroups Account Settings" in window 1
3. Change to window 2
4. Select "Edit|Mail & Newsgroups Account Settings" in window 2

Result:
Nothing happens.

Expected result:
Bring the already open Account Settings dialog to front.
(Assignee)

Comment 1

15 years ago
Created attachment 139112 [details] [diff] [review]
Patch
(Assignee)

Comment 2

15 years ago
Comment on attachment 139112 [details] [diff] [review]
Patch

timeless, could you review? Thanks!
Attachment #139112 - Flags: review?(timeless)

Updated

15 years ago
Attachment #139112 - Flags: superreview?(bienvenu)
Attachment #139112 - Flags: review?(timeless)
Attachment #139112 - Flags: review+

Comment 3

15 years ago
Comment on attachment 139112 [details] [diff] [review]
Patch

+	 if (server)
+	     existingAccountManager.selectServer(server, null);

I'm not sure about this part - if the existing account manager window already
had a different server selected, I'm not sure that the new request should
clobber that selection. Probably nicer	to just focus it.
(Assignee)

Comment 4

15 years ago
> I'm not sure about this part - if the existing account manager window already
> had a different server selected, I'm not sure that the new request should
> clobber that selection. Probably nicer	to just focus it.

On the other hand when the Account Manager is called via the context menu item
"Properties" from the folder pane, the user might expect to have the account
selected he just clicked on. Also the data entered into the pane that was
selected before is not lost.

I see both the pros and cons, so I'm going to attach a second patch which
behaves like you suggest. Just review the patch you like more. I'm fine with
both solutions.
(Assignee)

Comment 5

15 years ago
Created attachment 139579 [details] [diff] [review]
Just focus the Account Manager

Comment 6

15 years ago
Comment on attachment 139579 [details] [diff] [review]
Just focus the Account Manager

I don't feel that strongly either way but I marginally prefer this - not having
the server selected might remind the user that they already had the account
settings up :-)
Attachment #139579 - Flags: superreview+
(Assignee)

Comment 7

15 years ago
Comment on attachment 139579 [details] [diff] [review]
Just focus the Account Manager

timeless: Could you review this small change and check the patch in if it's ok?
Thanks!
Attachment #139579 - Flags: review?(timeless)
(Assignee)

Updated

15 years ago
Attachment #139112 - Flags: superreview?(bienvenu)

Updated

15 years ago
Attachment #139579 - Flags: review?(timeless) → review+
(Assignee)

Comment 8

15 years ago
Checked in by timeless. :-)
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.