223300 - Bookmarks manager and selecting new Personal Toolbar doesn't work

Status: VERIFIED DUPLICATE of bug 205739

Description

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

When i wants to assign a new folder as PT inside the bookmarks manager it
doesn't work. The old folder is always shown again within the PT.

Reproducible: Always

Steps to Reproduce:
1. Select new folder within the bookmarks manager
2. Click "Set as Bookmarks Toolbar Folder" 
Actual Results:  
After the click the new folder isn't assigned and i get following entries within
the location column of bookmarks manager:

Old Folder             rdf:#$zV4r53
New Folder             NC:PersonalToolbarFolder

Additionally the rechanging to the old folder isn't available - menu entry is
grayed out.

Expected Results:  
The new selected folder should replace the old one inside the PT.

I found out that the entries inside the bookmarks.html aren't updated correctly.

I expect following behavior:
Changing the PT should move the attributes PERSONAL_TOOLBAR_FOLDER="true" and
ID="NC:PersonalToolbarFolder" to the new folder. The old one get an new
ID-Attribute.

Actually behavior:
Both attributes stay within the old folder and aren't moved. After i manually
move the attributes and restart Firebird my new PT is shown.

Comment 1

[Mike Connor [:mconnor]]

reporter, if you try a current nightly, what happens? this code has been
recently rewritten so this should work without issues

Comment 2

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6a) Gecko/20031025
Firebird/0.7+

You are right. The actual nighly build shows right behavior. So we can mark this
bug as fixed. But some informations for me because i'm interested. Does the
rewrite starts before the FB 0.7 release or within the 0.7+ trunk? 

In my opinion it's bad that this bug damages the bookmark manager of FB 0.7. 

Comment 3

[Mike Connor [:mconnor]]

its actually a longstanding bug, I wanted to make sure you were talking about
the same issue before duping it though.

*** This bug has been marked as a duplicate of 205739 ***

Comment 4

[Simon Paquet [:sipaq]]

verified.

Comment 5

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change