223304 - AddNote doesn't report errors if it can't write to notes.txt

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[timeless]

MozillaTest had:
-rw-r--r--    1 nobody   nobody        117 Sep 21 10:00 notes.txt

egrep '^(User|Group) ' /etc/httpd/conf/httpd.conf
User apache
Group apache

Using addnote resulted in the normal your comment was added message. it should
have complained

Comment 1

[timeless]

Attachment: draft

Comment 2

[timeless]

Comment on attachment 133928 [details] [diff] [review]
draft

can you test this?

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 133928 [details] [diff] [review]
draft

doesn't compile.  Complains about || being overloaded.	Changing the test to:

$cant_print = 1 unless close NOTES;

Makes it work.

I still don't like the patch, but it works. :)	 I think it would be cleaner to
use a -w test before attempting to open it to begin with.

Comment 4

[cls]

Attachment: v2.0

Comment 5

[Mike Taylor [:bear]]

Comment on attachment 224273 [details] [diff] [review]
v2.0

I agree that this is not the best way to solve the issue.  Tinderbox2 writes each note to it's own file (named for the tree, build and time) and then html generation code pulls them in when it runs.

Comment 6

[cls]

Checking the error result of the open() is functionality equivalent to the -w test.  Using separate files for each comment is beyond the (simple) scope of the bug and should be an enhancement request.

Checking in webtools/tinderbox/addnote.cgi;
/cvsroot/mozilla/webtools/tinderbox/addnote.cgi,v  <--  addnote.cgi
new revision: 1.17; previous revision: 1.16
done