223331 - After closing all windows, first new window is broken

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

If you close all the firebird browser windows, the first new one you open has
some problems - e.g. bookmarks haven't loaded etc. This is because of an
incorrect assumption about the opener made in browser.js:Startup()

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

-> me, 0.7.1

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: Patch to fix

On MacOS X, null check the sidebar box element, as it can be null if the opener
is the hidden window.

Comment 3

[Wayne Woods]

I assume this is technically a duplicate of bug 206752, although the fix is
here, so maybe that bug should now be duped against this one. Not that I'm
complaining, I'm just happy that you've found a fix :)

I also assume this will also fix bug 206456, bug 206933, bug 215176 and bug
220534, which probably should have been duped to the earlier bug anyway. I'm not
sure if the remaining issues in bug 204418 pertain to this or not.

Comment 4

[Wayne Woods]

WFM 20031024 Firebird/0.7+. Thanks Ben! I assume you checked in a patch.

All of the other bugs listed in my last comment seem to be fixed as well (except
for bug 204418, which I assume is a different issue altogether: a number of menu
things are still awry when NO windows are open at all). 

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed, 1.6a trunk and 1.5br

Wayne - yes, the menu problems with no windows open is different. 

Comment 6

[Simon Paquet [:sipaq]]

*** Bug 206456 has been marked as a duplicate of this bug. ***

Comment 7

[Simon Paquet [:sipaq]]

*** Bug 215176 has been marked as a duplicate of this bug. ***

Comment 8

[Simon Paquet [:sipaq]]

*** Bug 206933 has been marked as a duplicate of this bug. ***

Comment 9

[Simon Paquet [:sipaq]]

*** Bug 220534 has been marked as a duplicate of this bug. ***

Comment 10

[Simon Paquet [:sipaq]]

verified fixed

Comment 11

[James Anthony]

*** Bug 220454 has been marked as a duplicate of this bug. ***