223373 - Should always have a security manager

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

After talking with jst tonight, we decided that not having a security manager in
e.g., nsContentUtils is bad.  I'll fix this up for beta.

-----------------------------------------------------------------------------
<caillon> It seems that there should always be some kind of security manager. 
If some embeddor doesn't care about security (what are they smoking?) then I
think they should implement a manager which just allows everything.

<jst> I agree. Not having a security manager is silly. We should never need to
check if a security manager poitner is non-null, it should be assumed.
Implementors can write out that stubs out the methods and allows everything, as
you said.  I bet that would eliminate some ammount of silly code, up for
sweaping over the tree and cleaning shit up?
-----------------------------------------------------------------------------

Comment 1

[Johnny Stenback (:jst)]

PS: Please excuse all those typos and inconsistencies in the above writing from
me. I was in dental surgery yesterday and I was (and I still am) on some really
nice drugs when I wrote the above :-)

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch

...and it goes a little something like this.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 134359 [details] [diff] [review]
Patch

r+sr=bzbarsky, but why do we have this "iniatilizing" boolen?  It's only used
inside an assert.  Should it be #ifdef DEBUG?

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Yeah, that seems redundant.  I removed the initializing variable since it is
pretty much useless now.  I also had to change nsContentUtils::sInitialized to
non-debug and to not assert on shutdown since we end up calling
nsContentUtils::Shutdown() twice on app shutdown (once for module shutdown, once
for xpcom shutdown).  I am talked to jst about this yesterday and he was fine
with it.  I'll post a new patch for posterity before checking in.

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Updated

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Fix checked in.