nspr makefiles use of @echo defeats -s flag to make

RESOLVED WONTFIX

Status

NSPR
NSPR
--
enhancement
RESOLVED WONTFIX
15 years ago
15 years ago

People

(Reporter: timeless, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

15 years ago
Steps to reproduce:
1. build seamonkey so that the next time you build seamonkey there won't be
anything in nspr that needs to be built.
2. 
I:\build\mozilla>make -s -f client.mk build_all

Actual results:
Adding client.mk options from I:\build\mozilla\debug.mozconfig:
    MOZ_OBJDIR=$(TOPSRCDIR)/debug-$(CONFIG_GUESS)
cd config; /usr/bin/make -j1 export
cd pr; /usr/bin/make -j1 export
...
tier_1: dbm jpeg modules/zlib modules/zlib/standalone

Expected results:
Adding client.mk options from I:\build\mozilla\debug.mozconfig:
    MOZ_OBJDIR=$(TOPSRCDIR)/debug-$(CONFIG_GUESS)
tier_1: dbm jpeg modules/zlib modules/zlib/standalone

Why this happens:
nspr makefiles have stuff like this:
	@echo "cd pr/tests; $(MAKE) $@"
	@$(MAKE) -C pr/tests $@
(Assignee)

Comment 1

15 years ago
I like to see which target we are passing to
$(MAKE), e.g., clean, export, or libs.
@echo $(MAKE) $@ is the only way I know to do
that.  $(MAKE) itself only prints the directory
in which the sub-make is done but not the target
it makes.

Are Mozilla's makefiles not using @echo?
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → WONTFIX
(Assignee)

Comment 2

15 years ago
Is the purpose of "make -s" to see the compiler warnings more easily?

It seems that "ar" echoes the name of the output .a file.
You need to log in before you can comment on or make changes to this bug.