223404 - IMAP ACL checking is case sensitive

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Kevin Teuscher]

Using myrealbox.com, the imap server give me a username of kTeuscher.  In my
setup for both mozilla and thunderbird, I have my username set to kteuscher. 
Because of this, I receive the correct rights, but the icons for special folders
(inbox, trash, junk) aren't shown correctly.
The checking of user rights should use a case insensitive check, so that the
previously obtained rights can be found.

Patch upcoming.

Comment 1

[Kevin Teuscher]

Attachment: Patch to change to case insensitive comparisons

Attached a patch to change all the usernames to lowercase for comparing in
nsMsgIMAPFolderACL::SetFolderRightsForUser and GetRightsStringForUser.

Kevin

Comment 2

[Kevin Teuscher]

Comment on attachment 133939 [details] [diff] [review]
Patch to change to case insensitive comparisons

Requesting a review and a suggestion for sr

Comment 3

[Jungshik Shin]

case-insesitivity is a bit more subtle. Your patch uses two different methods of
lower-casing. It should be all right as long as username stays within the ASCII
repertoire, but I'm not sure if that's the case with IMAP. 

Comment 4

[David :Bienvenu]

Attachment: tweaked fix

Hi Kevin - I looked at your fix and the existing code was bugging me, so I
looked into it a little. The existing code was leaking memory because it was
never freeing the PL_strdup'ed string. So I replaced it with an nsCAutoString,
which allowed me to use the same ToLowerCase routine that you were using so
we'll definitely have consistent results, and fix the leak. Do you want to try
this patch?

Comment 5

[Kevin Teuscher]

David:  I'll try it after the weekend.  I had thought about changing the
oldUsername so that I could use the same method, but I would have done it for
sure if I had caught on to that leak. 

jshin:  If I have interpreted rfc3501 correctly, I'm pretty sure that the userid
has to be 7-bit ASCII.  Also, David has now changed to use the same method for
both strings.

Kevin

Comment 6

[Kevin Teuscher]

Comment on attachment 133939 [details] [diff] [review]
Patch to change to case insensitive comparisons

remove requests

Comment 7

[Kevin Teuscher]

David:  Your tweaked version worked for me.

Kevin

Comment 8

[Kevin Teuscher]

Comment on attachment 134044 [details] [diff] [review]
tweaked fix

Just a reminder; get whoever you want for a review

Comment 9

[David :Bienvenu]

fix checked in, sr=mscott