223408 - View - Layout Menu needs to use radio buttons instead of check marks

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[George Kennedy]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6a) Gecko/20031021 Camino/0.7+
Build Identifier: Mozilla Thunderbird 0.3 (20031013)

On the mac if you use the View-Layout menu to change to a different layout it
check marks the one selected.  Then if you go back and change to a different
layout it will check mark that one as well.  You can actually end up with all 3
check marked at the same time.  A restart of thunderbird corrects the problem
but if you change layouts it will do it again.

Reproducible: Always

Steps to Reproduce:
1.Select View-Layout.  Note that by default Classic is check marked.
2.Select a different layout.
3.Now Select View-Layout again. Now you will have check marks by both Classic
and the other view you selected.

Actual Results:  
Ended up with everything check marked.

Expected Results:  
This menu should only allow one item at a time to be check marked.

Comment 1

[Stephen Walker]

They are radios already and I doubt Scott changed them to checkboxes on the 0.3
branch.

Comment 2

[matt haines]

(In reply to comment #1)
> They are radios already and I doubt Scott changed them to checkboxes on the 0.3
> branch.

version 0.7.1 (20040626) has this same problem. the check marks don't act like radio buttons, 
they just all turn on and stay on.

Comment 3

[Scott Lamb]

I encountered this same behavior with version 0.7.3 (20040803) on OS X.

This also occurs with the "View | Headers" menu. Most of the others (say, "View | Message Body As") 
seem to be unaffected.

I'm not too surprised this is OS X-only. OS X doesn't have a class to manage radio menu items for you. 
In Cocoa, there's just the NSMenuItem class. When you toggle one item on, you have to invoke 
[NSMenuItem setState:NSOffState] on the others yourself. So it'd be easy to forget to do this on OS X, 
yet have it be correct on other platforms.

OS X also doesn't visually distinguish between checkbox items and radio items in menus. Not sure why. 
You can set images for on state and off states manually, but nothing seems to do that. For example, the 
"Window" menu in every application displays the current window (clearly a one-at-a-time selection) 
with a checkbox in the on state of each item, and no image in the off state.

Comment 4

[Matthew (lilmatt) Willis]

This behavior continues on Mozilla Thunderbird 0.8 (20040913)

Comment 5

[Matthew (lilmatt) Willis]

Attachment: Patch adds name to radio mutually exclusive radio elements

Disclaimer: This is the first patch I've submitted.

This patch adds the name "viewlayoutgroup" to each of the three layout radio
choices, grouping them together in a mutually exclusive group.

Comment 6

[Matthew (lilmatt) Willis]

Attachment: AVIARY version of same patch

Same patch as above, built for AVIARY

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 159232 [details] [diff] [review]
AVIARY version of same patch

please don't request approval until you've gotten sufficient reviews. thanks.

Comment 8

[Matthew (lilmatt) Willis]

Taking this bug

Comment 9

[Scott MacGregor]

fixed on the branch and the trunk. Thanks for the patch!

Comment 10

[trix supremo]

verified on latest 20041124 builds

Comment 11

[Doug Wright]

*** Bug 260683 has been marked as a duplicate of this bug. ***