223420 - Unsetting review- flag sends incorrect email

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD:  Whatever bugzilla.mozilla.org is using right not

STEPS TO REPRODUCE:

1)  xxx@yyy creates an attachment
2 [details] [diff] [review])  xxx@yyy sets a "review?" flag aimed at the email address foo@bar
3)  foo@bar sets the flag to "review-"
4)  xxx@yyy resets the flag back to "review?" aimed at foo@bar

EXPECTED RESULTS:

foo@bar gets an email saying that review is being requested

ACTUAL RESULTS:

foo@bar gets an email that says:

    Subject: review denied: [Bug XXXX] Summary [Attachment XXX] Attachment
             description

    <xxx@yyy> has denied <foo@bar>'s request for review:

Comment 1

[Ken Mason]

I am having a similar (seemingly related) problem.  Consider a flag that goes 
from ? to +, then back to ?.  In that scenario, when the flag is changed from 
+ to ?, a "flag granted" email is sent to the person who originally set the 
flag to +.  This is consistently reproducible using bugzilla version 2.18.1.

 

Comment 2

[Frédéric Buclin]

fixed!