223442 - consider moving mac-specific files in gfx/public to a mac directory

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Mac, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

gfx/public contains  nsRepeater.h nsWatchTask.h
these are only used on MacOS... however, Makefile.in exports nsRepeater.h for
all OSes, and for all of these files, it would be imho clearer if they would be
in a mac-specific directory (gfx/public/mac or something like that), so that
people don't think this stuff is available on all platforms/must be implemented
by all toolkits.

Comment 1

[Jeremy Lea]

Attachment: Remove nsWatchTask.h

nsRepeater.h is long gone, and nsWatchTask.h is not connected to the build, but is still in gfx/public.  It should be deleted.  Adding a dependency on 376791, which is the gfx cleanup bug...

The patch is just a placeholder for a cvs remove...

Comment 2

[Jeremy Lea]

Comment on attachment 319095 [details] [diff] [review]
Remove nsWatchTask.h

Request to delete now unused header.  Not part of build (according to lxr).

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 319095 [details] [diff] [review]
Remove nsWatchTask.h

NPOTB doesn't need a=beltzner, but it has it; thanks for checking! :)

Comment 4

[Reed Loden [:reed]]

Does that one patch fix this bug completely?

Comment 5

[Reed Loden [:reed]]

Removing gfx/public/nsWatchTask.h;
/cvsroot/mozilla/gfx/public/nsWatchTask.h,v  <--  nsWatchTask.h
new revision: delete; previous revision: 1.6
done

Comment 6

[Jeremy Lea]

(In reply to comment #4)
> Does that one patch fix this bug completely?

Yes.  There are no more mac specific files in gfx.  Marking as fixed.