22346 - backouts should occur in reverse chronological order

Status: VERIFIED FIXED

(Webtools Graveyard :: Bonsai, defect, P2)

Description

[cls]

When backing out a group of checkouts, the backout should occur in reverse
chronological order in case the checkins being backed out modified the same file
more than once.  A good example of this is
http://cvs-mirror.mozilla.org/webtools/bonsai/cvsquery.cgi?module=SeaMonkeyAll&branch=HEAD&cvsroot=/cvsroot&date=day&who=pinkerton%25netscape.com&generateBackoutCVSCommands=1

I received a conflict on nsScrollbarFrame.cpp because it tried to reverse the
fix changes first rather than last.

Comment 1

[Terry Weissman]

*** Bug 24014 has been marked as a duplicate of this bug. ***

Comment 2

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This bug bit me today, trying to do a bonsai-backout of warren's changes.  The
lines are listed in exactly the reverse order from the way they should be.  See,
for example:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=mozilla%2Fconfigure.in&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=month&mindate=&maxdate=&cvsroot=%2Fcvsroot&generateBackoutCVSCommands=1

which is the commands file to backout all configure.in changes in the past
month.  It should list from most current to least current.

Comment 4

[cls]

Attachment: Just reverse the list when printing out the backout script

Comment 5

[cls]

Can someone verify that this change works so that we can update bonsai before
the next set of major backouts? :-)

Comment 6

[cls]

patch checked in.

Comment 7

[timeless]

vrfy fixed
1.26 cls%seawood.org Mar 8 2001
and by use