223473 - Query not resubmitted after changing columns.

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Adrian Kalaveshi]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; .NET CLR 1.1.4322)
Build Identifier: 

Once you have results from your query select change columns and select another 
field to display. Commit this and it says submitting your query with changed 
columns but you do not get any results back. You have to go to the query page 
again and submit the query yourself.

When you want to automatically refresh to another page, you send a 
header that looks something like:

Refresh:0; url=http://bugzilla/something?something=something

In IE 6.x, if that header exceeds the maximum size of 263 characters, 
the refresh won't occur.  This probably works in other browsers.

A work-around would be to add a "Click here if the page does not automatically 
refresh." link.


Reproducible: Always

Steps to Reproduce:
(Using IE 6.0)
1. run a query
2. change the columns

Actual Results:  
Remains at a page that says:

Resubmitting your query with new columns... 

Expected Results:  
Either presented the bug list with new columns or presented the user with a 
link.

Comment 1

[Jonathan Schatz]

another workaround is to use a meta-refresh tag, which ie happily follows
regardless of the url length (that's how i patched it here).

Comment 2

[Vlad Dascalu]

Reference: http://fplanque.net/Blog/itTrends/2003/08/31/p367

Confirming, taking.

Comment 3

[Dave Miller [:justdave]]

not quite a dupe but definitely related to bug 214466 (and the hack being done
for that might accidently fix this in the process)

Comment 4

[Vlad Dascalu]

Attachment: Patch

Tested on my localhost, works as expected.

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 135467 [details] [diff] [review]
Patch

OK, I'll go for this.

>Index: colchange.cgi
>@@ -104,6 +104,7 @@
> 
>     print $cgi->redirect("buglist.cgi?$::FORM{'rememberedquery'}");
>     $vars->{'message'} = "change_columns";
>+    $vars->{'redirect_url'} = "buglist.cgi?$::FORM{'rememberedquery'}";

You should put the $vars->{'redirect_url'} assignment in front of the redirect
line and reference it from there, so if it ever changes, it only has to be
changed once.

The rest looks good.

Comment 6

[Vlad Dascalu]

Comment on attachment 135467 [details] [diff] [review]
Patch

Bug 214466 is related to that. However, we still aren't providing the user with
a "Click here if the page fails to refresh automatically."

Providing such a message is a good idea, in my opinion. I've seen it sometimes
on downloading some files (click this link if the download fails to start
automatically). Ironically, the "automatic start" was in that case a popup
window, and since I had popups disabled, I had to click that link to start it
manually, so the link proved very useful.

Also, maybe some browsers provide/will provide via their preferences to disable
automatic redirects. Or maybe in IE 4.0, Lynx etc, for one reason or another,
that redirect could fail. It's always good to provide with a "manual" way to
"go ahead", just to be on the safe side. Most users won't even probably see
that manual redirect message (in my Mozilla I don't even see the "Resubmitting
your query" thing, the redirect happens pretty fast).

In addition, bug 214466 doesn't seem to fix in all cases the 256 char limit.

Comment 7

[Vlad Dascalu]

Attachment: Version 2

Version 2. :)

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 135468 [details] [diff] [review]
Version 2

I sort of have an aversion to having a link that says "here", but I can't think
of a better way to say it in this circumstance.  This will work. :)  r=justdave

Comment 9

[Vlad Dascalu]

Another way would be:

If the page fails to load automatically, you can manually <link>go ahead</link>.

but that doesn't sound a lot better to me.

Comment 10

[Vlad Dascalu]

Checking in colchange.cgi;
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v  <--  colchange.cgi
new revision: 1.37; previous revision: 1.36
done
Checking in template/en/default/global/messages.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v
 <--  messages.html.tmpl
new revision: 1.17; previous revision: 1.16
done