Closed Bug 223542 Opened 21 years ago Closed 19 years ago

Weird scrolling using autoscroll over iframe / frame

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ruffo, Assigned: tuukka.tolvanen)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

patch1.1
4.31 KB, patch
mconnor
: review+
asa
: approval1.8b4+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

Rendering of the page is ok.
But if you scroll to the bottom with the middle-click-pointer thing

 ( ^ )
 ( V )

and then put the mouse pointer to the webring table, the browser scrolls up and
down in a weird way


Reproducible: Always

Steps to Reproduce:
1. go to that page
2. go to the bottom
3. middle-click once
4. put the pointer to the web-ring table

Actual Results:  
Scrolls up and down in with non-deterministic fashion

Expected Results:  
Just be quiet.

Default theme used
Confirming on linux Gecko/20031024 Firebird/0.7+
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Summary: Weird scrolling → Weird scrolling using autoscroll over iframe
This looks (after an initial look at the page in question) like the autoscroll
is calculating it's position relative to the iframe's origin when over it. This
I think explains all the scrolling that then ensures. :)
this bug is fixed when the autoscroll looks at what frame it is initially
showed, and the scrolling should only occur relative to that frame.

It is also when you have two frames vertically and you scroll in the top one,
and move your mouse in the bottom one, the top one will go back up.

The bug also exists in firefox 0.8

voted.
Depends on: 237755
*** Bug 237755 has been marked as a duplicate of this bug. ***
Flags: blocking1.0?
Flags: blocking1.0? → blocking1.0-
Blocks: 212273
Able to replicate on xp firefox 0.9.1 at page:
http://optimoz.mozdev.org/piemenus/

Added vote.
*** Bug 253085 has been marked as a duplicate of this bug. ***
*** Bug 251903 has been marked as a duplicate of this bug. ***
No longer depends on: 237755
Summary: Weird scrolling using autoscroll over iframe → Weird scrolling using autoscroll over iframe / frame
this approach wfm on linux aviary with the testcase pages.
Assignee: firefox → t.bugz
Status: NEW → ASSIGNED
Attachment #161730 - Flags: review?(firefox)
*** Bug 270739 has been marked as a duplicate of this bug. ***
asking for blocking-aviary1.1. A patch exists, and it's quite annoying issue.
Flags: blocking-aviary1.1?
Version: unspecified → Trunk
*** Bug 272094 has been marked as a duplicate of this bug. ***
Not sure, but in bugzilla, if I have 2 bugs open in tabs, after closing one,
and/or hitting reply in the other; it will get the contents of the two mixed
together. Not sure if that is this bug or not.
(In reply to comment #12)
> Not sure, but in bugzilla, if I have 2 bugs open in tabs, after closing one,
> and/or hitting reply in the other; it will get the contents of the two mixed
> together. Not sure if that is this bug or not.

This is not a Firefox issue.  It's due to an issue with bugzilla and viewing
multiple bugs at once.
*** Bug 296024 has been marked as a duplicate of this bug. ***
*** Bug 296024 has been marked as a duplicate of this bug. ***
Tuuka, maybe it is better to reassign to mconnor@steelgryphon.com?
*** Bug 290364 has been marked as a duplicate of this bug. ***
*** Bug 296244 has been marked as a duplicate of this bug. ***
Attachment #161730 - Flags: review?(firefox) → review?(mconnor)
minusing, but if the patch works out, it'll be fixed rsn.
Flags: blocking-aviary1.1? → blocking-aviary1.1-
Attached patch patch1.1 — — Splinter Review 
bitrot (bug 280584) update to patch1
Attachment #161730 - Attachment is obsolete: true
Attachment #186474 - Flags: review?(mconnor)
Attachment #161730 - Flags: review?(mconnor)
(In reply to comment #20)
> Created an attachment (id=186474) [edit]
> patch1.1
> 
> bitrot (bug 280584) update to patch1

How exactly do we use this patch, I am new to this bug stuff :P

> How exactly do we use this patch, I am new to this bug stuff :P

apply the changes with 'patch' to a current source tree or the contents of one
of the jar files in a trunk nightly install. Or wait for the fix to be checked
in and a version with the fix to be released :)
Patch works great on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050619 Firefox/1.0+ (applied manually to toolkit.jar)

Surely this should be severity: normal at least as most pages have ads, and most
ads are in iframes, so this occurs extremely often and is disorienting etc. when
it does happen.
Comment on attachment 186474 [details] [diff] [review]
patch1.1

using screen coords is really bad, perf-wise, see discussion the bookmarks
contextmenu bug
Attachment #186474 - Flags: review?(mconnor) → review-
I think Mike meant these remarks: bug 296004, comment 21 and bug 242833, comment 14.
In this case I think using screen coordinates would be OK. You're only doing it
once per mouse move, if I understand the code correctly. That should not be a
problem.
Comment on attachment 186474 [details] [diff] [review]
patch1.1

In the light of comment 26, asking for rereview.
Attachment #186474 - Flags: review- → review?(mconnor)
Comment on attachment 186474 [details] [diff] [review]
patch1.1

let's get this in for b4, early, and get some testing in.
Attachment #186474 - Flags: review?(mconnor) → review+
Attachment #186474 - Flags: approval-aviary1.1a2?
Attachment #186474 - Flags: approval-aviary1.1a2? → approval1.8b4?
Attachment #186474 - Flags: approval1.8b4? → approval1.8b4+
checked in,
http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=2005-07-17%2006:43&maxdate=2005-07-17%2006:43
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
I saw that in Deer Park Alpha 2, the nightly build on July 18 seems to fix the
autoscroll problem. But additionally, it seems that if you start an autoscroll
inside a text ad (like in a forum, since those text ads can be right in the
middle) autoscroll will not function. The page simply will not scroll. Try going
to http://www.dslreports.com/forum/remark,13599896~mode=flat~days=9999~start=20
and starting an autoscroll right in the middle of the text ad.
(In reply to comment #30)
> I saw that in Deer Park Alpha 2, the nightly build on July 18 seems to fix the
> autoscroll problem. But additionally, it seems that if you start an autoscroll
> inside a text ad (like in a forum, since those text ads can be right in the
> middle) autoscroll will not function. The page simply will not scroll. Try going
> to http://www.dslreports.com/forum/remark,13599896~mode=flat~days=9999~start=20
> and starting an autoscroll right in the middle of the text ad.

If you start autoscrolling inside an iframe, you will be bound by it.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: