22357 - Menu should use implicit separators.

Status: VERIFIED WONTFIX

(Core :: XUL, enhancement, P3)

Description

[Matthew Tuck [:CodeMachine]]

I've seen instances where you get separators with nothing below you.  I think
Moz should automatically handle this situation properly, and also the one where
there are two separators together.

Basically this would involve changing:

<menu value="File"/>
  <menupopup>
    <menuitem value="New..."/>
    <menuitem value="Close"/>
    <menuseparator/>
    <menuitem value="Save"/>
    <menuitem value="Save As..."/>
    <menuseparator/>
    <menuitem value="Exit"/>
  </menupopup>
</menu>

(graciously lifted from the XUL docs) to:

<menu value="File"/>
  <menupopup>
    <menugroup>
      <menuitem value="New..."/>
      <menuitem value="Close"/>
    </menugroup>
    <menugroup>
      <menuitem value="Save"/>
      <menuitem value="Save As..."/>
    </menugroup>
    <menugroup>
      <menuitem value="Exit"/>
    </menugroup>
  </menupopup>
</menu>

It's a bit longer, and maybe you might know how to make it shorter, but anyway,
the point is that separators are implicit rather than explicit, that is, between
the groups.  If one menu group happens to be empty, it generates no separator,
and there is no scope for multiple separators.

I've seen id attributes on menuseparators in navigator.xul, so I'm not sure
whether this provides a feature that my proposal couldn't achieve.

Comment 1

[Paul MacQuiddy]

Sairuh, your chance to learn some XUL :-)

Comment 2

[Peter Trudelle]

reassigning to saari for consideration, cc hyatt.

Comment 3

[David Hyatt]

Taking this.

Comment 4

[Matthew Tuck [:CodeMachine]]

The other option of course is to actually trash unneeded explicit separators,
which is probably easier to implement but I'm of the opinion a grouping scheme
is more logical.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Taking menu/popup bugs.

Comment 6

[Mike Pinkerton (not reading bugmail)]

These are some good ideas, but we need explicit separators for style and we don't 
like the idea of altering the content model implicitly.

Comment 7

[leger]

BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.

Comment 8

[sairuh (rarely reading bugmail)]

verifying.