223574 - Empty Trash should Compact Trash when done.

Status: RESOLVED WORKSFORME

(Thunderbird :: Message Compose Window, defect)

Description

[rich cowan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla Thunderbird 0.3

If you empty the trash, the disk space of the trash is
not cleaned up.

Reproducible: Always

Steps to Reproduce:
1. Empty the trash for a single account, using right-click on the trash folder

Actual Results:  
After emptying the trash, look in the profile, located at:
  C:\Documents and Settings\default\Application Data\Thunderbird\Profiles
   and the trash file you emptied still has stuff in it.


Expected Results:  
The compact folder operation should be run on the trash
after it is emptied.

Note: this should be really easy to fix.

This might also apply to the global "empty trash" item in the file menu,
depending on others' opinions.

Comment 1

[Ric]

From bug  247444, which is being closed as a duplicate of this bug
See also  205756, 197605 and 237464

The one issue not brought up in the other reports is one of security.
If I have a shared computer, and who doesn't, I may be thinking certain messages
are gone. When in fact they are still there waiting to be discovered.

In some legal settings, this could be a serious problem.  

At the very least, in the next update, a warning needs to go in to the help
system that mail is not deleted until the message is deleted, trash is emptied
and both the original folder and the trash folders are compacted.

Comment 2

[Ric]

*** Bug 247444 has been marked as a duplicate of this bug. ***

Comment 3

[Mike Cowperthwaite]

I am not seeing this symptom, in MailNews or TB -- the Trash folder is 
immediately reduced to zero bytes when emptied.

Rich Cowan, do you still have this problem?

Comment 4

[Ric]

(In reply to comment #3)
> do you still have this problem?


Yes - 
TB version 0.8 (20040913) on XP Pro w/SP2
When I empty the trash, the trash folder in the mail client shows no messages -
howevever, the 'trash' folder on the hard drive does not change size.
-Ric

Comment 5

[Mike Cowperthwaite]

(In reply to comment #4)
> When I empty the trash, the trash folder in the mail client shows no messages
> - howevever, the 'trash' folder on the hard drive does not change size.

Do you say it doesn't change size because you're viewing it in the Windows 
Explorer and the size value doesn't update?  What happens if you type F5 to 
refresh the view in Explorer -- does it *continue* to show nonzero size?

Comment 6

[Ric]

(In reply to comment #4)

OK, Sorry about my last post -  I tested this just now - empty trash DOES reduce
file size on the hard drive. I should have re-verified the path to my message
storage, which had changed the last time I updated.

This now works correctly in all the Trash folders I have.  Thank you.

Simular behaviour  -

I have a set of Local Folders along with several accounts and their folders.
Mostly, a rule moves new mail out of the account and into the local
folder. 

If I manually move the message from the account folder (inbox) to the local
inbox, then the account folder does not reduce in size.  When I add something to
it, the size increases.  

When the rule moves the message - the account inbox temporarily increases
then returns to the previous size.  Say the account inbox is 0
and I send a message, when recieved it may jump to 100k, within a second, the
size returns back to 0.

There is something different about how those messages are processed
from my manually dragging and dropping a message into a folder
vs having the rule process it.

The rule I use is  "if match criteria, then move to new folder"  There is no
'delete' portion of the rule.

Comment 7

[rich cowan]

YES, THIS BUG SEEMS TO BE FIXED!!!

I am the original reporter and I just tested it in 0.9.

This bug should be closed.  Any way I can get additional
privileges so I can close bugs I fixed?

Comment 8

[Mike Cowperthwaite]

Reopened to fix resolution.  Please don't use "fixed" unless you can point to a 
particular patch that solved the problem.