223618 - minors fixes to cocoaEmbed tests

Status: RESOLVED WONTFIX

(Core Graveyard :: Embedding: Mac, defect)

Description

[S Woodside]

There were some hardcoded paths in these projects. specifically /Users/conrad
and /Volumes/moose/floppy also fixed a few other problems

Comment 1

[S Woodside]

Attachment: patch to projects NSBrowserView and CocoaEmbed

Comment 2

[Nicholas Allen]

Do you really want to be adding the path
/Volumes/MacintoshHD/Users/woodside/sandbox/moz/mozilla/embedding/browser/cocoa/build
?

Comment 3

[S Woodside]

Attachment: oops, fixed another hardcoded directory

errr... no.

BTW I added the headre into the project so it would be included in a
project-wide search.

Comment 4

[Conrad Carlen (not reading bugmail)]

Comment on attachment 134090 [details] [diff] [review]
oops, fixed another hardcoded directory

Thanks. As a final check, the project files shouldn't contain any occurances of
"/Volumes/*" or "/Users/*" Assuming you did that, r=ccarlen.

Comment 5

[Mike Pinkerton (not reading bugmail)]

when i try to apply this patch, this is what i get:

<pink> [mozilla/embedding] : patch -p0 --dry-run < ~/Desktop/p2.txt 
patching file browser/cocoa/NSBrowserView.pbproj/project.pbxproj
patching file tests/cocoaEmbed/CocoaEmbed.pbproj/project.pbxproj
patch: **** malformed patch at line 81: @@ -324,10 +314,11 @@

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

CocoaEmbed is dead and gone.