There were some hardcoded paths in these projects. specifically /Users/conrad and /Volumes/moose/floppy also fixed a few other problems
Do you really want to be adding the path /Volumes/MacintoshHD/Users/woodside/sandbox/moz/mozilla/embedding/browser/cocoa/build ?
Created attachment 134090 [details] [diff] [review] oops, fixed another hardcoded directory errr... no. BTW I added the headre into the project so it would be included in a project-wide search.
Comment on attachment 134090 [details] [diff] [review] oops, fixed another hardcoded directory Thanks. As a final check, the project files shouldn't contain any occurances of "/Volumes/*" or "/Users/*" Assuming you did that, r=ccarlen.
Attachment #134090 - Flags: review+
Attachment #134090 - Flags: superreview?(sfraser) → superreview+
when i try to apply this patch, this is what i get: <pink> [mozilla/embedding] : patch -p0 --dry-run < ~/Desktop/p2.txt patching file browser/cocoa/NSBrowserView.pbproj/project.pbxproj patching file tests/cocoaEmbed/CocoaEmbed.pbproj/project.pbxproj patch: **** malformed patch at line 81: @@ -324,10 +314,11 @@
CocoaEmbed is dead and gone.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.