view page source and view selection source are broken, xml error displayed instead

VERIFIED FIXED

Status

()

Firefox
General
--
major
VERIFIED FIXED
15 years ago
15 years ago

People

(Reporter: Steffen Wilberg, Assigned: Steffen Wilberg)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
View Page Source and View Selection Source is broken; an xml error is displayed
instead.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20031026
Firebird/0.7+ (Steffen)

The reason is that Pierre changed viewSource.xul and viewPartialSource.xul
and introduced these lines: <?xml version="1.0"?>
in this checkin:
http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=10%2F25%2F2003+20%3A28&maxdate=10%2F25%2F2003+20%3A28

The xml error is:
XML Parsing Error: xml processing instruction not at start of external entity
Location: chrome://global/content/viewSource.xul
Line Number 2, Column 1:
<?xml version="1.0"?>
^

If you remove these lines, it works again.
(Assignee)

Comment 1

15 years ago
Created attachment 134167 [details] [diff] [review]
patch

This patch moves the <xml> tag to the top of viewSource.xul and
viewPartialSource.xul. It has to be in the very first line. Another solution
would be to remove the empty line after the # signs but I think this is safer.

Comment 2

15 years ago
-> Steffen
Assignee: p_ch → steffen.wilberg

Comment 3

15 years ago
Thanks for this one too!
marking fixed.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 4

15 years ago
verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.