223871 - Thunderbird takes over OS X minimize window keyboard shortcut

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Abe White]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-us) AppleWebKit/103u (KHTML, like Gecko) Safari/100
Build Identifier: Mozilla Thunderbird 0.3 (20031013)

The standard system-wide keyboard shortcut for minimizing the current window in OS X is cmd-M.  
Thunderbird's OS X news reader client uses this shortcut for composing a new news message 
instead.  It should use cmd-N (for "New Message") or anything else -- interfering with system-wide 
shortcuts is a major usability issue (IMO).

Reproducible: Always

Steps to Reproduce:
1. Open Thunderbird
2. Hit cmd-M
3. There is no step 3!
Actual Results:  
Compose window comes up.

Expected Results:  
Thunderbird window should minimize.

Comment 1

[xolaware.llc]

agree with bug; the old Mozilla browser used to use Cmd-Shift-M for this
purpose.  this would be a natural choice, as it would leave Cmd-M for it's
intended OS X purpose, and would also make for a seamless transition for those
who are used to it from Mozilla.

Comment 2

[Stephen Walker]

The key should be Cmd-Shift-M since late January, can someone on Mac OS X verify?

Comment 3

[Tanner Lovelace]

Cmd-Shift-M and Cmd-M do the exact same thing on Thunderbird 0.7 on OS X (10.3.4).  Both bring up 
the compose a new message window.

Comment 4

[Ben Fowler]

version 0.6+ (20040820)

Behaviour is as Comment 3. Also Cmd-M is the shortcut key in the menu.

Comment 5

[Matthew (lilmatt) Willis]

I have a patch to disable Cmd-M opening a new message (which then becomes
Shift-Cmd-M, but I haven't yet worked on making Cmd-M minimize the window. I
need to look up how that's done. I think it's CollapseWindow() in Carbon.

Anyway, if we want to disable the annoyance before we actually fix this bug, let
me know and I'll attach the patch.

Comment 6

[Matthew (lilmatt) Willis]

Attachment: Patch changes keyboard shortcut for new msg from Accel-M to Shift-Accel-M

This patch fixes half of this bug.

mozilla/mail/base/content/mailOverlay.xul already had an #ifdef for Mac OS X,
changing the "New Message" keyboard shortcut from Accel-M to Shift-Accel-M. The
#ifdef wasn't being preprocessed on build, resulting in both key definition
sections being enabled in the chrome jar, hence both key combinations bringing
up a new message. 

I deleted the whitespace before the #ifdef #else and #endif statements, and I
added the * preprocess flag for mailOverlay.xul to mozilla/mail/base/jar.mn so
the .xul's #ifdef would get interpreted before it was added to
chrome/messenger.jar

Comment 7

[Matthew (lilmatt) Willis]

Attachment: Revised patch for mozilla trunk -- removes extra trailing spaces

Comment 8

[Matthew (lilmatt) Willis]

Attachment: AVIARY version of same (revised) patch

This is a version of the revised patch, built for AVIARY.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 159234 [details] [diff] [review]
AVIARY version of same (revised) patch

please don't request approval until you've gotten sufficient reviews. thanks.

Comment 10

[Matthew (lilmatt) Willis]

Taking this bug

Comment 11

[Scott MacGregor]

Thanks Matt. Fix checked into the branch and trunk. 

Comment 12

[sairuh (rarely reading bugmail)]

tested with 2004101502-0.8 on OS X 10.3.5: menu items look fine and the keyboard
shortcut also works nicely in tbird.

note that bug 204636 is still an issue, where cmd+M doesn't minimize either
firefox or tbird.

Comment 13

[Stephen Walker]

*** Bug 266881 has been marked as a duplicate of this bug. ***