When someone marks a bug as a duplicate of another bug, then in both bugs a comment is posted that notifies the CC list about the action. However, in that comment, the term "bug" is not customized and it should be replaced with the customized terms that are defined in the template system.
This still exist in 2.18.1. There are (at least) two messages *** Bug 23 has been marked as a duplicate of this bug. *** *** This bug has been marked as a duplicate of 21 ***
This is also an issue for localization – the hardcoded string cannot be translated. (I'd wanted to add l12y to the keywords list, but it seems I am not 'empowered' enough. ;-) )
Created attachment 238388 [details] [diff] [review] v1 Okay, here. This fixes it.
Oh, and I did test the above patch.
Problem is that this breaks autolinkification...
(In reply to comment #5) > Problem is that this breaks autolinkification... True. We do have a bug filed to customize autolinkification, somewhere, I think. Either that, or we should just eliminate these messages, since the data is stored in the bugs_activity table anyway. Usually people only change terms.bug once, and they also customize the code to highlight it, but that's not always the case. I could use get_text to get the current "bug" term, for autolinkification, also.
(In reply to comment #6) > Either that, or we should just eliminate these messages, since the data is > stored in the bugs_activity table anyway. Did you hear the cryout when the comment from an added attachment when creating a bug was found missing? I believe people will want these comments on their bugs... > I could use get_text to get the current "bug" term, for autolinkification, > also. This would be great!
Comment on attachment 238388 [details] [diff] [review] v1 I agree with Marc, autolinkification is a problem here. This has nothing to do with terms.bug but with the entire string itself, see Bugzilla::Template::quoteUrls() at line 344.
fix bug 191362 then the issue will have gone B-)
Created attachment 238477 [details] [diff] [review] v2 Okay, this fixes it--now the highlightable term can be customized.
Created attachment 238478 [details] [diff] [review] Actual v2 That other one was the wrong patch.
Comment on attachment 238478 [details] [diff] [review] Actual v2 works fine. r=LpSolit
Checking in Bugzilla.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla.pm,v <-- Bugzilla.pm new revision: 1.50; previous revision: 1.49 done Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.342; previous revision: 1.341 done Checking in Bugzilla/BugMail.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v <-- BugMail.pm new revision: 1.91; previous revision: 1.90 done Checking in Bugzilla/Template.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v <-- Template.pm new revision: 1.62; previous revision: 1.61 done Checking in Bugzilla/Util.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v <-- Util.pm new revision: 1.54; previous revision: 1.53 done Checking in template/en/default/global/messages.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v <-- messages.html.tmpl new revision: 1.45; previous revision: 1.44 done
um. i bet i don't like the way this is fixed. if bugzilla has 5 locales, what locale is used for the message?
(In reply to comment #14) > if bugzilla has 5 locales, what locale is used for the message? The locale of the user performing the change. This is why comments just shouldn't contain this information at all. You can file another bug about that, if you want.
this should be backed out for the reasons specified in comment 14, comment 15, and bug 353656.
i think i managed to convince colin that this is doing more harm than good. i'm setting this to blocking because i want it on the radar of things that needs to be backed out. i don't know of some other way to do it.
No, bug 353656 is a blocker, not this bug. Don't use CVS HEAD or a development release if you don't want things to break.