223880 - "marked a duplicate" messages cannot be localized

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Vlad Dascalu]

When someone marks a bug as a duplicate of another bug, then in both bugs a
comment is posted that notifies the CC list about the action. However, in that
comment, the term "bug" is not customized and it should be replaced with the
customized terms that are defined in the template system.

Comment 1

[Brian Peschel]

This still exist in 2.18.1.  There are (at least) two messages

*** Bug 23 has been marked as a duplicate of this bug. ***
*** This bug has been marked as a duplicate of 21 ***

Comment 2

[Petr Kadlec]

This is also an issue for localization – the hardcoded string cannot be
translated. (I'd wanted to add l12y to the keywords list, but it seems I am not
'empowered' enough. ;-) )

Comment 3

[Max Kanat-Alexander]

Attachment: v1

Okay, here. This fixes it.

Comment 4

[Max Kanat-Alexander]

Oh, and I did test the above patch.

Comment 5

[Marc Schumann [:Wurblzap]]

Problem is that this breaks autolinkification...

Comment 6

[Max Kanat-Alexander]

(In reply to comment #5)
> Problem is that this breaks autolinkification...

  True. We do have a bug filed to customize autolinkification, somewhere, I think.

  Either that, or we should just eliminate these messages, since the data is stored in the bugs_activity table anyway.

  Usually people only change terms.bug once, and they also customize the code to highlight it, but that's not always the case.

  I could use get_text to get the current "bug" term, for autolinkification, also.

Comment 7

[Marc Schumann [:Wurblzap]]

(In reply to comment #6)
>   Either that, or we should just eliminate these messages, since the data is
> stored in the bugs_activity table anyway.

Did you hear the cryout when the comment from an added attachment when creating a bug was found missing?
I believe people will want these comments on their bugs...

>   I could use get_text to get the current "bug" term, for autolinkification,
> also.

This would be great!

Comment 8

[Frédéric Buclin]

Comment on attachment 238388 [details] [diff] [review]
v1

I agree with Marc, autolinkification is a problem here. This has nothing to do with terms.bug but with the entire string itself, see Bugzilla::Template::quoteUrls() at line 344.

Comment 9

[victory <[e-mail]>]

fix bug 191362 then the issue will have gone B-)

Comment 10

[Max Kanat-Alexander]

Attachment: v2

Okay, this fixes it--now the highlightable term can be customized.

Comment 11

[Max Kanat-Alexander]

Attachment: Actual v2

That other one was the wrong patch.

Comment 12

[Frédéric Buclin]

Comment on attachment 238478 [details] [diff] [review]
Actual v2

works fine. r=LpSolit

Comment 13

[Max Kanat-Alexander]

Checking in Bugzilla.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla.pm,v  <--  Bugzilla.pm
new revision: 1.50; previous revision: 1.49
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.342; previous revision: 1.341
done
Checking in Bugzilla/BugMail.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v  <--  BugMail.pm
new revision: 1.91; previous revision: 1.90
done
Checking in Bugzilla/Template.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v  <--  Template.pm
new revision: 1.62; previous revision: 1.61
done
Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.54; previous revision: 1.53
done
Checking in template/en/default/global/messages.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v  <--  messages.html.tmpl
new revision: 1.45; previous revision: 1.44
done

Comment 14

[timeless]

um. i bet i don't like the way this is fixed.

if bugzilla has 5 locales, what locale is used for the message?

Comment 15

[Max Kanat-Alexander]

(In reply to comment #14)
> if bugzilla has 5 locales, what locale is used for the message?

  The locale of the user performing the change.

  This is why comments just shouldn't contain this information at all.

  You can file another bug about that, if you want.

Comment 16

[timeless]

this should be backed out for the reasons specified in comment 14, comment 15, and bug 353656.

Comment 17

[timeless]

i think i managed to convince colin that this is doing more harm than good. i'm setting this to blocking because i want it on the radar of things that needs to be backed out. i don't know of some other way to do it.

Comment 18

[Max Kanat-Alexander]

No, bug 353656 is a blocker, not this bug.

Don't use CVS HEAD or a development release if you don't want things to break.