Closed Bug 223943 Opened 21 years ago Closed 16 years ago

expand "mailnews.headers.showUserAgent" to include x-newsreader

Categories

(Thunderbird :: Mail Window Front End, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b1

People

(Reporter: cso, Assigned: cso)

References

Details

Attachments

(2 files, 5 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20031024 Firebird/0.7+
Build Identifier: Mozilla Thunderbird 0.4a (20031026)

Currently if "mailnews.headers.showUserAgent" is set to true, an X-Mailer: and
User-Agent: header are displayed on the message view, both for email and
newsgroups. However, some nntp clients use the x-newsreader header as their
UserAgent.

It would be nice if "mailnews.headers.showUserAgent" also showed the
X-NewsReader: header if it exists.

Reproducible: Always

Steps to Reproduce:
1. Load a Newsgroup message with an X-Newsreader header.
Actual Results:  
No UserAgent was displayed

Expected Results:  
Preferably, displayed the UserAgent as being the value of X-Newsreader.
Attached patch Possible Patch (obsolete) — Splinter Review
I can't test this as I've never managed to get Mozilla (Thunderbird) to compile
correctly... but it might work.

<crosses fingers>
Attachment #134316 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 134316 [details] [diff] [review]
Possible Patch

This won't work unless you also patch
http://lxr.mozilla.org/seamonkey/source/mailnews/mime/emitters/src/nsMimeHtmlEm
itter.cpp#228
Attachment #134316 - Flags: review?(neil.parkwaycc.co.uk)
I wondered that - I'll do that if I can get mozilla to build and am able to test it.
This patch actually works when I compile it.
Attachment #134316 - Attachment is obsolete: true
Attachment #134347 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 134347 [details] [diff] [review]
Patch
[Checkin: See comment 9]

Assuming this compiles... So, which newsreaders set x-newsreader?
Attachment #134347 - Flags: review?(neil.parkwaycc.co.uk) → review+
The ones I've seen are Outlook Express 6 and Forte Agent although there may be more.
Attached patch Thunderbird Part (obsolete) — Splinter Review
This provides the x-newsreader as user-agent on Thunderbird. This needs at
least part of the previous patch as well.
Since I can't recall having submitted patches to the Mozilla Seamonkey part of
the tree before, how do I go about getting this patch advanced through the
stages before checkin?
Attachment #134347 - Flags: superreview?(mscott)
Attachment #134347 - Flags: superreview?(mscott) → superreview?(bienvenu)
Attachment #134347 - Flags: superreview?(bienvenu) → superreview+
Product: Browser → Seamonkey
Comment on attachment 134347 [details] [diff] [review]
Patch
[Checkin: See comment 9]

mozilla/mailnews/mime/emitters/src/nsMimeHtmlEmitter.cpp	1.79
mozilla/mailnews/base/resources/content/msgHdrViewOverlay.js	1.127
Attachment #134347 - Attachment is obsolete: true
Assignee: sspitzer → mail
This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/
Attached patch Thunderbird Part (v2) (obsolete) — Splinter Review
Thunderbird part of this change... its already been implemented on the suite
applications, but the thunderbird part got missed.
Assignee: mail → colin.ogilvie
Attachment #134365 - Attachment is obsolete: true
Status: UNCONFIRMED → ASSIGNED
Attachment #197569 - Flags: review?(bienvenu)
Component: MailNews: Main Mail Window → Mail Window Front End
Flags: review?(bienvenu)
Flags: review+
Product: Mozilla Application Suite → Thunderbird
Comment on attachment 197569 [details] [diff] [review]
Thunderbird Part (v2)

Hmm, apparently the review flag went AWOL when I moved this bug to Thunderbird.
Attachment #197569 - Flags: review?(bienvenu)
Attachment #197569 - Flags: review?(bienvenu) → review+
QA Contact: esther → front-end
Was this patch ever checked in?
No.
OS: Windows XP → All
Hardware: PC → All
Whiteboard: [patchlove] [just need trivial unbitrotting]
Attached patch unbitrotted patch (obsolete) — Splinter Review
Attachment #197569 - Attachment is obsolete: true
Attachment #347430 - Flags: review?(mkmelin+mozilla)
Comment on attachment 347430 [details] [diff] [review]
unbitrotted patch

Thx, Gary!

>+        if (lowerCaseHeaderName == "x-mailer" ||
>+          lowerCaseHeaderName == "x-newsreader" ||
>+          lowerCaseHeaderName == "x-mimeole")
>           lowerCaseHeaderName = "user-agent";

Please align the condition as

        if (lowerCaseHeaderName == "x-mailer" ||
            lowerCaseHeaderName == "x-newsreader" ||
            lowerCaseHeaderName == "x-mimeole")
          lowerCaseHeaderName = "user-agent";
Attachment #347430 - Flags: review?(mkmelin+mozilla) → review+
Whiteboard: [patchlove] [just need trivial unbitrotting] → [patchlove]
Attached patch unbitrotted patch v2 (obsolete) — Splinter Review
Formatting changed as per previous comment. Bringing over review+.
Attachment #347430 - Attachment is obsolete: true
Attachment #347477 - Flags: review+
Magnus, could you please check this in as well?
Keywords: checkin-needed
Attachment #134347 - Attachment description: Patch → Patch [Checkin: See comment 9]
Attachment #134347 - Attachment is obsolete: false
Component: Mail Window Front End → Backend
Product: Thunderbird → MailNews Core
QA Contact: front-end → backend
Comment on attachment 347477 [details] [diff] [review]
unbitrotted patch v2

>-        // for consistancy sake, let's force all header names to be lower case so
>+        // For consistency's sake, let us force all header names to be lower

(Is the |'s| actually wanted ?)

>+        // If we have an x-mailer, x-newsreader, or x-mimeole string,
>+        // put it in the user-agent slot which we know how to handle already.
>+        if (lowerCaseHeaderName == "x-mailer" ||
>+            lowerCaseHeaderName == "x-newsreader" ||
>+            lowerCaseHeaderName == "x-mimeole")

(This could use a regexp, like |/^x-...$/.test(lowerCaseHeaderName)|.
(In reply to comment #19)
> (From update of attachment 347477 [details] [diff] [review])
> >-        // for consistancy sake, let's force all header names to be lower case so
> >+        // For consistency's sake, let us force all header names to be lower
> 
> (Is the |'s| actually wanted ?)

For correct language, yes.

> 
> >+        // If we have an x-mailer, x-newsreader, or x-mimeole string,
> >+        // put it in the user-agent slot which we know how to handle already.
> >+        if (lowerCaseHeaderName == "x-mailer" ||
> >+            lowerCaseHeaderName == "x-newsreader" ||
> >+            lowerCaseHeaderName == "x-mimeole")
> 
> (This could use a regexp, like |/^x-...$/.test(lowerCaseHeaderName)|.

Not sure.. Magnus, thoughts?
You can use 
if (/^x-(mailer|mimeole|newsreader)$/.test(lowerCaseHeaderName))

... if you want.
Re-requesting review to ensure this tastes good for TB.
Attachment #347477 - Attachment is obsolete: true
Attachment #347691 - Flags: review?(mkmelin+mozilla)
Comment on attachment 347691 [details] [diff] [review]
unbitrotted patch v3 - TB
[Checkin: Comment 24]

Looks good, thx! Will check it in shortly.
Attachment #347691 - Flags: review?(mkmelin+mozilla) → review+
changeset:   1080:a96e4d724c04
http://hg.mozilla.org/comm-central/rev/a96e4d724c04

->FIXED (for thunderbird, seamonkey needs it's own bug)
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Component: Backend → Mail Window Front End
Keywords: checkin-needed
Product: MailNews Core → Thunderbird
QA Contact: backend → front-end
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
Blocks: TB2SM
Attachment #347691 - Attachment description: unbitrotted patch v3 - TB → unbitrotted patch v3 - TB [Checkin: See comment 24]
Whiteboard: [patchlove]
Attachment #347691 - Attachment description: unbitrotted patch v3 - TB [Checkin: See comment 24] → unbitrotted patch v3 - TB [Checkin: Comment 24]
Blocks: 467192
No longer blocks: TB2SM
(In reply to comment #24)
> changeset:   1080:a96e4d724c04
> http://hg.mozilla.org/comm-central/rev/a96e4d724c04
> 
> ->FIXED (for thunderbird, seamonkey needs it's own bug)

SeaNonkey was already fixed, see comment 9 or comment 11 ;-)
(In reply to comment #25)
> SeaNonkey was already fixed, see comment 9 or comment 11 ;-)

Exact. Though I just filed bug 467192 to sync' to the new code...
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: