223963 - problems with mail compose insert link toolbar drop down

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Scott MacGregor]

problems with mail compose insert link toolbar drop down

the images don't match the text. 

screenshot coming.

Comment 1

[Scott MacGregor]

Attachment: screen shot

Comment 2

[[e-mail]]

Looks like another regression from bug 207243 :-(

Comment 3

[Patrick Thompson]

Yes, it is a regression of bug 207243. Below are the updated stylesheet changes
to editor/editorFormatToolbar.css to correct the problem (starting at line 372):

/* ..... insert menu ..... */

#InsertPopup > menuitem {
  list-style-image: url("chrome://editor/skin/icons/btn1.gif");
}

#InsertLinkItem {
  -moz-image-region: rect(16px 16px 32px 0);
}

#InsertLinkItem:hover {
  -moz-image-region: rect(16px 32px 32px 16px);
}

#InsertAnchorItem {
  -moz-image-region: rect(128px 16px 144px 0);
}

#InsertAnchorItem:hover {
  -moz-image-region: rect(128px 32px 144px 16px);
}

#InsertImageItem {
  -moz-image-region: rect(144px 16px 160px 0);
}

#InsertImageItem:hover {
  -moz-image-region: rect(144px 32px 160px 16px);
}

#InsertHRuleItem {
  -moz-image-region: rect(32px 16px 48px 0);
}

#InsertHRuleItem:hover {
  -moz-image-region: rect(32px 32px 48px 16px);
}

#InsertTableItem {
  -moz-image-region: rect(112px 16px 128px 0);
}

#InsertTableItem:hover {
  -moz-image-region: rect(112px 32px 128px 16px);
}

Comment 4

[David :Bienvenu]

-> Neil

Comment 5

[[e-mail]]

Attachment: Pat's patch

Pat's CSS, turned into a patch. r=me fwiw.

Comment 6

[[e-mail]]

Comment on attachment 134362 [details] [diff] [review]
Pat's patch

Looking for editor moa (at least) on this.

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 134362 [details] [diff] [review]
Pat's patch

yes, those changes should only affect msg compose format toolbar anyway.

r=[e-mail]

Comment 8

[[e-mail]]

Accepting.

Comment 9

[[e-mail]]

Fix checked in.