Closed Bug 224039 Opened 21 years ago Closed 21 years ago

crash in nsGenericHTMLElement::FindAttributeDependence if colgroup element has style attribute

Categories

(Core :: Layout: Tables, defect, P1)

Product:
Core
Component:
Layout: Tables
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.6alpha

People

(Reporter: ajfitzpatrick, Assigned: ajfitzpatrick)

Details

(Keywords: crash, Whiteboard: [patch])

Attachments

(2 files)

Test case
192 bytes, text/html
Details
Patch
599 bytes, patch
bzbarsky
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6a) Gecko/20031029
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6a) Gecko/20031029

A web page containing <colgroup span="2" style="width: 50%"> crashes Mozilla.

It looks like the problem is in nsHTMLTableColElement.cpp; the span_attribute
array isn't terminated with nsnull.

Reproducible: Always

Steps to Reproduce:
Attached file Test case — 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch
        — 
          — Splinter Review
      

    


  

    
    

    
  
Marking NEW since it has testcase + patch.
Please ask for review/superreview (probably bzbarsky & dbaron).
Severity: normal → critical
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: crash

    
    

    
  
Comment on attachment 134386 [details] [diff] [review]
Patch

doh.  r+sr=bzbarsky.  Could we take this for 1.7a, please?  This is a very
simple crash fix with no bad side-effects whatsoever...

        Attachment #134386 -
        Flags: superreview+

        Attachment #134386 -
        Flags: review+

        Attachment #134386 -
        Flags: approval1.6a?

    
    

    
  
I meant 1.6a, of course.. :(

Adam, if the tree reopens and this patch has not been checked in yet, please
send me an email and I'll land it.

    
    

    
  
Taking bug to make sure this gets in.
Assignee: table → dbaron
OS: Linux → All
Priority: -- → P1
Hardware: PC → All
Whiteboard: [patch]
Target Milestone: --- → mozilla1.6alpha

    
    

    
  
Fix checked in to trunk, 2003-10-29 17:53 -0800.

Thanks for the patch.
Assignee: dbaron → ajfitzpatrick

    
    

    
  
marking fixed
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED

        Attachment #134386 -
        Flags: approval1.6a?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: