224044 - browser freezes when using top navigation

Status: RESOLVED FIXED

(Tech Evangelism Graveyard :: English US, defect)

Description

[Steve Hart]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

In the page http://www.marketleap when I click the tools link at the bottom of
the page I have discovered Firebird freezes around 50% of the time. I have to
control, alt, delete to close firebird.

Reproducible: Sometimes

Steps to Reproduce:
1.Goto Marketleap.com
2.Click on tools

Actual Results:  
50% chance of freezing firebird

Expected Results:  
No freeze

Comment 1

[Simon Paquet [:sipaq]]

Confirming on both Seamonkey and Firebird latest nightlies from 2003-10-28.
Moving to Layout. The page also uses javascript, but since the javascript
console gives no errors I don't think this is a JS-issue. Please reassign if you
disagree.

Comment 2

[Boris Zbarsky [:bzbarsky]]

> but since the javascript console gives no errors I don't think this is a
> JS-issue

You know, "valid" JS code (syntactically) can be incorrect (logically).

The page has (as you will see if you turn on strict warnings):

  var i=0;var rv=true;while(document.links[i]!=x){i++;}

(in linktools.js).

Now it seems like document.links[i] is never equal to "x" here, especially once
i is big enough that it's just undefined all the time.

The problem is that the script loaded at the very end of the page (the "Keylime
Software" script) rewrites the onclick handlers to use "kll_this" instead of
"this".  So the above code (which is triggered off an onclick handler) malfunctions.

Comment 3

[Simon Paquet [:sipaq]]

I've sent the evangelism letter to [e-mail] and via a contact
form with IE.

Comment 4

[Simon Paquet [:sipaq]]

|From: Marketleap Webmaster
|
|Hi Simon,
|
|Thank you for bringing this to our attention.  I have updated the page
|and using Firebird 0.7 the issue appears to be resolved.  
|
|I have also made a couple of trips through the site and this issue does
|not seem to affect any other pages.  
|
|Thanks again and please let me know if there are any other issues that
|may be causing problems.

I can confirm that this works now. Marking FIXED. Thanks bz for the thorough
examination. That was very helpful in getting this bug fixed so quickly.