224148 - Setting "review+" flag sends flag setter mail if there was no "review?" flag

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Boris Zbarsky [:bzbarsky]]

VERSION:  Whatever bugzilla.mozilla.org runs

PROBLEM DESCRIPTION:

If I set "review+" on a patch which had no "review?" flag, I get an email
telling me that I fulfilled my own request (which I never made, of course).

I know I set the flag.  I don't need to get mail about it.  I certainly don't
need misleading mail about it....

I can't recall this ever happening before, and I'm pretty sure I've encountered
this exact situation after the new request system was in place.  Did the
mozilla.org version of bugzilla get updated recently?

See also bug 223420 and bug 214179 for similar issues...

Comment 1

[Christian Reis]

Yeah, I've seen this myself.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Hmm, this might be because of bug 183788, the fix for which I recently applied
to b.m.o.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Note that the changelog for the bug (eg
http://bugzilla.mozilla.org/show_activity.cgi?id=180049) shows me changing the
flag from (in this case) "superreview?" to "superreview+" whereas in reality I
changed it from nothing to "superreview+" (note that there is no earlier change
to set "superreview?").

Comment 4

[Boris Zbarsky [:bzbarsky]]

Er, ignore comment 3.  I just can't read a change log, apparently.. ;)

Comment 5

[Frédéric Buclin]

*** Bug 320043 has been marked as a duplicate of this bug. ***

Comment 6

[Frédéric Buclin]

fixed!