Code cleanup: nsMsgSortOrder and nsMsgSortType

RESOLVED FIXED

Status

SeaMonkey
MailNews: Message Display
--
trivial
RESOLVED FIXED
14 years ago
10 years ago

People

(Reporter: Matthew Elvey, Assigned: Bruno 'Aqualon' Escherl)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
http://lxr.mozilla.org/seamonkey/search?string=nsMsgSortOrder shows
the three enums defined by 
enum nsMsgSortOrder
are all unused.
(Reporter)

Comment 1

14 years ago
Ditto : http://lxr.mozilla.org/seamonkey/search?string=nsMsgSortType .

Am I missing something?  Since TBird is becoming the flagship, should I be
looking there instead? (I happened upon these whil looking to change the default
sort from ascending to descending.)
You should change both Seamonkey and TBird, if you have the time.
Matthew, are you planning on working on this?  If not, can you/I punt it back to
nobody@mozilla.org?
(Reporter)

Comment 4

14 years ago
Belatedly punting.  My compile platform is out of commission, no time to fix.
Assignee: bugzillaPost120030in → nobody
Product: Browser → Seamonkey

Updated

10 years ago
Assignee: nobody → mail
Severity: normal → trivial
QA Contact: esther
(Assignee)

Comment 5

10 years ago
Created attachment 285770 [details] [diff] [review]
Remove nsMsgSortOrder and nsMsgSortType

According to MXR neither nsMsgSortOrder nor nsMsgSortType are used anywhere in the code.
Assignee: mail → aqualon
Status: NEW → ASSIGNED
Attachment #285770 - Flags: superreview?(bienvenu)
Attachment #285770 - Flags: review?(mnyromyr)
(Assignee)

Updated

10 years ago
Summary: Code cleanup: nsMsgSortOrder → Code cleanup: nsMsgSortOrder and nsMsgSortType

Comment 6

10 years ago
Comment on attachment 285770 [details] [diff] [review]
Remove nsMsgSortOrder and nsMsgSortType

thx for the patch
Attachment #285770 - Flags: superreview?(bienvenu) → superreview+

Comment 7

10 years ago
Comment on attachment 285770 [details] [diff] [review]
Remove nsMsgSortOrder and nsMsgSortType

JFTR: we're using nsMsgViewSortOrder and nsMsgViewSortType these days.

Landed on trunk.
Attachment #285770 - Flags: review?(mnyromyr) → review+

Updated

10 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.