22428 - can't use mozilla to attach files to bugzilla

Status: VERIFIED FIXED

(Core :: Networking, defect, P1)

Description

[Dawn Endico]

When creating a new bug attachment the file picker under
the "Browse..." button only prints the file name, not the
entire path so when you submit the attachment, bugzilla
can't find the file and the operation fails.

Comment 1

[Peter Trudelle]

assigning to sdagley for triage.

Comment 2

[Steve Dagley]

Just out of curiosity, does this work on any platform?  I suspect we're only

using the file name rather than the complete path returned by the file picker.

Will investigate in detail after the holidays.

Comment 3

[Paul MacQuiddy]

this works on windows tip from 12/22, but I couldn't get it to work on linux
either, even if I type in the full correct path

Comment 4

[Chris McAfee]

duped bug was mac, marking all

Comment 5

[Chris McAfee]

*** Bug 6229 has been marked as a duplicate of this bug. ***

Comment 6

[Chris McAfee]

*** Bug 23432 has been marked as a duplicate of this bug. ***

Comment 7

[Avi Rappoport]

B13 on the Mac - problem is still open.

Comment 8

[Steve Dagley]

Attachment: log of network traffic during failed submit w/Mac Mozilla

Comment 9

[Steve Dagley]

I'v attached a log that shows the traffic between the Mac and Bugzilla when the 
submit fails.  It would appear that Bugzilla isn't recognizing the mime type for 
the attachment.  Any ideas jud or gagan?

Comment 10

[Gagan]

Attachment: test file to catch windows behaviour on posting

Comment 11

[Gagan]

Attachment: the actual windows transaction for the previous attachement

Comment 12

[Gagan]

Attachment: linux test

Comment 13

[Gagan]

Attachment: trying again (this time on mozilla) :)

Comment 14

[leger]

Putting on PDT+ radar for beta1. And adding dogfood to keyword.

Comment 15

[Steve Dagley]

Attachment: Testing

Comment 16

[Steve Dagley]

Attachment: Testing

Comment 17

[Steve Dagley]

Attachment: Testing

Comment 18

[Steve Dagley]

Attachment: Yes, testing

Comment 19

[Steve Dagley]

Attachment: Again

Comment 20

[Steve Dagley]

Attachment: Once more, with feeling!

Comment 21

[Steve Dagley]

Problem was that we weren't properly calculating the size of the form submit 
(left out the size of the actual data in the file).  Changed 
nsFormFrame::ProcessAsMultipart to use an nsILocalFile to get file size rather 
than PR_GetFileInfo as the path to the file is in native format and 
PR_GetFileInfo doesn't handle native Mac paths.

Comment 22

[Paul MacQuiddy]

okay, this seems to be fixed for small plain text file, but I'm having trouble, 
especially on mac and sometimes on windows, with uploading larger gif and jpg 
files. Linux does not exhibit the problem. I'm attaching a file (using 4.x) that 
hangs when trying to attach using mozilla on mac0s8.6 and win98 using 2/4 
builds.

Comment 23

[Paul MacQuiddy]

Attachment: 110kb jpg file that can't be attached with win/mac mozilla

Comment 24

[Steve Dagley]

Ok, this is now a different problem and looks to be somewhere in Necko.  The 
attachment built in layout/html/forms/src/nsFormFrame.cpp looks to be the 
appropriate 110K or so.  Watching the data being sent to Bugzilla when trying to 
submit the attachment however shows that we send about 48K and then stall out.  
This would be bad.  Reassigning to warren for disposition.  Also bumping the 
priority and severity settings since it is keyed as a beta1 dogfood bug.

Comment 25

[Warren Harris]

Jud, can you look into this one?

Comment 26

[Judson Valeski]

yea, this is floating around in several bugs. 48k seems to be about what I was 
seeing. cc'ing rpotts. we're reaching some sort of cap in the socket 
transport/pipe code where we slow to a crawl then the server times us out.

Comment 27

[Judson Valeski]

over to rpotts. we think we've seen this before.

Comment 28

[Judson Valeski]

*** Bug 17967 has been marked as a duplicate of this bug. ***

Comment 29

[Eric Pollmann]

*** Bug 22819 has been marked as a duplicate of this bug. ***

Comment 30

[Judson Valeski]

I think I just noticed that changing window focus (w/ other apps) caused us to 
fall out of PR_Poll() and into or doWrite() function, each time I changed focus 
:-/

Comment 31

[Judson Valeski]

scratch that last comment. I'm tired.

Comment 32

[Gagan]

This might be related to bug 27022

Comment 33

[rpotts (gone)]

Attachment: Yet another test...

Comment 34

[rpotts (gone)]

Attachment: Testing with a 259k image

Comment 35

[rpotts (gone)]

Warren's change to mozilla\netwerk\base\src\nsBufferedStreams.cpp (r 1.3) has
fixed this problem.

Comment 36

[Paul MacQuiddy]

Rick, I tried attaching the 259k image using today's 2/14 windows build (win98) 
and I'm still seeing the same behavior, it starts transferring then just spins. 
Linux is still ok, no mac build available.

A small text file is still ok.

re-opening

Comment 37

[rpotts (gone)]

*** Bug 27356 has been marked as a duplicate of this bug. ***

Comment 38

[rpotts (gone)]

Attachment: yet another test...

Comment 39

[rpotts (gone)]

I don't get it...  I just tried attaching the 259K JPEG image again and it
*worked* fine.

Is this still a problem?  Maybe on 2/14 there was some other Windows
instability? Since it worked on Linux :-)

I'm closing it again :-)  Please open it up again if it's still a problem for
you...  I guess it might be a seamonkey only problem :-(

Comment 40

[Paul MacQuiddy]

Rick, yes it is still a problem for me. I tried on a different machine, win95
this time. Here's what I did:

1. Save the 259k file locally to my hard drive.
2. Launch mozilla and loads this bug
3. Click on Create a new Attachment
4 [details] [diff]. Click browse and select my file, which I have called big.gif
5. Add some comments, select image/gif as mime-type and submit

It just goes and goes and goes. What do mean when you say "I guess it must be a
seamonkey only problem". I'm using 2/17 Windows release commercial build. What
are you using?

cc:ing shrirang and sairuh who will please try this out on their NT machines.

Comment 41

[Paul MacQuiddy]

Attachment: attaching a 7k text file using 2/17 windows commercial

Comment 42

[Paul MacQuiddy]

Attachment: attaching 7.5k file using windows commercial 2/17

Comment 43

[rpotts (gone)]

I'm using a tip debug build (2/18/00) of mozilla.  I'll try it out on a 
commercial build tomorrow...

Comment 44

[Paul MacQuiddy]

seems maybe timing dependent, as I fail sometime even on the small plain text
file. I would suspect debug vs release or machine dependent as opposed to
commercial vs mozilla.

commercial build can be obtained at
ftp://sweetlou/products/client/seamonkey/windows/32bit/x86/ for netscape
internal folks

Comment 45

[rpotts (gone)]

Hmmm... Last time I closed this bug (on 2/11) I was able to create a 259K JPEG 
attachment using an optimized mozilla build :-(

I guess I'll just try creating attachments *lots* of times...  Beware for the 
flood of bugzilla notifications :-)

Comment 46

[rpotts (gone)]

Attachment: Trying the image attachment using commercial tip (2/18)

Comment 47

[rpotts (gone)]

Attachment: again...

Comment 48

[rpotts (gone)]

Attachment: again...

Comment 49

[rpotts (gone)]

Attachment: This time I'm attaching a text file (nsWebShell.cpp)

Comment 50

[shrirang khanzode]

Attachment: Attaching-File-using-WIN-Commercial-Build-2000021808m14

Comment 51

[rpotts (gone)]

Paul,  I think that this is a Win95/98 only bug...  I'm not seeing it under NT,
but I am seeing it on my Win98 box...

Were you testing on Win98 only?

Comment 52

[rpotts (gone)]

OK...  so I just tried it again on Win98 with the *same* build I'm running on
NT.  It fails on Win98, but works on WinNT.

Oh joy...  I'll start setting up a debug environment on my Win98 box :-(

Comment 53

[Paul MacQuiddy]

yes, i tried it on win95 and win98, shrir just tried it on NT and didn't have 
any problems. Strange.

Comment 54

[Paul MacQuiddy]

Attachment: trying big file on macintosh, 2/17 commercial release

Comment 55

[Paul MacQuiddy]

Attachment: trying small file on macintosh, 2/17 commercial release

Comment 56

[Paul MacQuiddy]

macintosh also only works with small files, i spin when tring the large gif

Comment 57

[Paul MacQuiddy]

Attachment: one more time on mac, large file

Comment 58

[Paul MacQuiddy]

hmmm, it actually worked a couple times, though it was still spinning...

Comment 59

[rpotts (gone)]

Attachment: 300K exe using Win98

Comment 60

[rpotts (gone)]

Attachment: one more time... (win98)

Comment 61

[rpotts (gone)]

Attachment: one more time... (win98)

Comment 62

[rpotts (gone)]

Attachment: and again... (win98)

Comment 63

[rpotts (gone)]

Attachment: yet again :-(

Comment 64

[rpotts (gone)]

Attachment: again on NT (for reference)

Comment 65

[rpotts (gone)]

Attachment: again on Win98

Comment 66

[rpotts (gone)]

Attachment: Again on NT for reference (this time it's an image)

Comment 67

[rpotts (gone)]

Attachment: again on Win98 (i'm beginning to get sick of this)

Comment 68

[rpotts (gone)]

Attachment: and again...

Comment 69

[rpotts (gone)]

Attachment: lets try this again - win98

Comment 70

[rpotts (gone)]

Attachment: I bet you're wishing you were not cc'ed on this bug :-)

Comment 71

[rpotts (gone)]

OK...  So I now know what's going on here...  It turns out that 
nsSocketTransport::doWriteFromStream(...) is *totally* busted!

This method reads a chunk of data from an input stream into a buffer and then 
sends it to the network...  If send() is unable to write the entire buffer, or 
God forbid E_WOULDBLOCK is returned, the unsent data is simply thrown away!!!

Fixing this will requre a bit of thought...  But at least I know what's causing 
the problem :-)

Comment 72

[rpotts (gone)]

Attachment: another test (nt this time)

Comment 73

[rpotts (gone)]

Attachment: and again... Its an image (nt)

Comment 74

[rpotts (gone)]

Attachment: Another image - Win98 with the patch

Comment 75

[rpotts (gone)]

I've checked the fix in...

Comment 76

[shrirang khanzode]

Attachment: Verifying attachment using build on NT

Comment 77

[shrirang khanzode]

Attachment: Verifying on Linux build

Comment 78

[shrirang khanzode]

Attachment: Verifying on mac build

Comment 79

[shrirang khanzode]

Attachment: Verifying on Win-98

Comment 80

[shrirang khanzode]

Attachment: verifying attachment on win-95

Comment 81

[shrirang khanzode]

Finally....Marking VERIFIED !