Some Customize Headers dialog clean up

RESOLVED FIXED

Status

SeaMonkey
MailNews: Message Display
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: Stefan Borggraefe, Assigned: Stefan Borggraefe)

Tracking

({access})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

14 years ago
The Customize Headers dialog is currently cut off when you are using larger
fonts. With my configuration the Ok and Cancel buttons of the dialog are not
reachable. I fixed this bug. While I was at it I also 

- added accesskeys to the dialog
- converted it to <dialog>
- made the dialog resizable. Until now this dialog remembered its size, but
wasn't resizable.

Patch follows...
(Assignee)

Comment 1

14 years ago
Created attachment 134671 [details] [diff] [review]
Patch
(Assignee)

Updated

14 years ago
Attachment #134671 - Flags: review?(neil.parkwaycc.co.uk)

Comment 2

14 years ago
Comment on attachment 134671 [details] [diff] [review]
Patch

This window needs extensive conversion if you really want to make it a
dialog... just fix the resizing for now.
(Assignee)

Comment 3

14 years ago
Created attachment 134902 [details] [diff] [review]
New Patch

Removed the conversion from window to dialog.
Attachment #134671 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #134671 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Updated

14 years ago
Attachment #134902 - Flags: review?(neil.parkwaycc.co.uk)

Comment 4

14 years ago
Comment on attachment 134902 [details] [diff] [review]
New Patch

>+        <label accesskey="&newMsgHeader.accesskey;" control="headerInput">&newMsgHeader.label;</label>
Change this to use value= so that you can see the access key :-)

>+              window.openDialog('chrome://messenger/content/CustomHeaders.xul', "", 'modal,centerscreen,resizable,titlebar,chrome', null);
The centerscreen appears to override the persist="screenX screenY"
(Assignee)

Comment 5

14 years ago
Created attachment 135323 [details] [diff] [review]
Even newer patch

Fixed the <label>. The centerscreen flag and screenX/screenY-persistence work
together like they should (Neil and I tested this again).
Attachment #134902 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #134902 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Updated

14 years ago
Attachment #135323 - Flags: superreview?(bienvenu)
Attachment #135323 - Flags: review?(neil.parkwaycc.co.uk)

Updated

14 years ago
Attachment #135323 - Flags: review?(neil.parkwaycc.co.uk) → review+

Updated

14 years ago
Attachment #135323 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Comment 6

14 years ago
Checked in by timeless. Marking FIXED.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.