uninitialized variable in nsNetSupportDialog.cpp

VERIFIED FIXED in M13

Status

SeaMonkey
UI Design
P1
normal
VERIFIED FIXED
18 years ago
13 years ago

People

(Reporter: Kathleen Brade, Assigned: davidm)

Tracking

Trunk
PowerPC
Mac System 8.5

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
I see a warning for an uninitialized variable in nsNetSupportDialog.cpp.
In nsNetSupportDialog::Select(), selectedIndex is declared before
  rv = prompter->Select( inDialogTitle, inMsg, inCount, inList,
outSelection,_retval );
but it isn't passed in as an argument.
The next line of code is to assign selectedIndex to outSelection.

Let's get this fixed soon...

Updated

18 years ago
Assignee: don → davidm
Priority: P3 → P1
Target Milestone: M13

Comment 1

18 years ago
David, is this your code?
(Assignee)

Comment 2

18 years ago
Yep. Non one should ever be using this code ( the class is obsolete) but it
should still be fixed sometime. I think the fix is to delete
	 PRInt32 selectedIndex;
     PRBool rtnValue;
	*outSelection = selectedIndex;
(Assignee)

Updated

18 years ago
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

18 years ago
Removed obsolete code. Made all the other code work the same way. Nothing to
verify here ( unless of course all the dialogs are broken tommorrow ;) ). I
tested on mac, win, and linux using both the browser and Mail so I don't expect
that to happen.

Comment 4

18 years ago
verified, all dialogues aren't broken :-)
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.