I see a warning for an uninitialized variable in nsNetSupportDialog.cpp. In nsNetSupportDialog::Select(), selectedIndex is declared before rv = prompter->Select( inDialogTitle, inMsg, inCount, inList, outSelection,_retval ); but it isn't passed in as an argument. The next line of code is to assign selectedIndex to outSelection. Let's get this fixed soon...
David, is this your code?
Yep. Non one should ever be using this code ( the class is obsolete) but it should still be fixed sometime. I think the fix is to delete PRInt32 selectedIndex; PRBool rtnValue; *outSelection = selectedIndex;
Removed obsolete code. Made all the other code work the same way. Nothing to verify here ( unless of course all the dialogs are broken tommorrow ;) ). I tested on mac, win, and linux using both the browser and Mail so I don't expect that to happen.
verified, all dialogues aren't broken :-)