Closed
Bug 224650
Opened 21 years ago
Closed 21 years ago
nsXPCOM.h included twice
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: d_king, Assigned: d_king)
Details
Attachments
(1 file)
|
630 bytes,
patch
|
edburns
:
review+
brendan
:
superreview+
|
Details | Diff | Splinter Review |
In mozilla/js/src/xpconnect/src/xpcprivate.h , there are two includes of nsXPCOM.h
|
Assignee | |
Updated•21 years ago
|
Severity: normal → trivial
|
|
Assignee | |
Comment 2•21 years ago
|
||
Removes duplicate include.
|
|
Assignee | |
Comment 3•21 years ago
|
||
Comment on attachment 138196 [details] [diff] [review]
Patch
Asking for "r".
Attachment #138196 -
Flags: review?(edburns)
Comment on attachment 138196 [details] [diff] [review]
Patch
r=edburns
Attachment #138196 -
Flags: review?(edburns) → review+
|
|
Assignee | |
Comment 5•21 years ago
|
||
Comment on attachment 138196 [details] [diff] [review]
Patch
Asking for "SR", keeping in mind that I have no check-in privs.
Attachment #138196 -
Flags: superreview?(idk)
|
||
Comment 6•21 years ago
|
||
Is not it wrong 'component' for this bug ?
This bug has nothing todo with Java to XPCOM bridge.
Java is not JavaScript
Please reassign this bug to correct component.
Thanks,
igor
|
|
Assignee | |
Comment 7•21 years ago
|
||
Opps, that was a silly mistake on my part.
Changing component.
Assignee: d_king → general
Component: Java to XPCOM Bridge → JavaScript Engine
QA Contact: avm → PhilSchwartau
|
|
Assignee | |
Comment 8•21 years ago
|
||
Comment on attachment 138196 [details] [diff] [review]
Patch
Changing SR request to match correct Component.
Attachment #138196 -
Flags: superreview?(Igor.Kushnirskiy) → superreview?(brendan)
|
||
Comment 9•21 years ago
|
||
Wrong component, still.
/be
Assignee: general → BradleyJunk
Component: JavaScript Engine → XPConnect
|
|
||
Comment 10•21 years ago
|
||
Comment on attachment 138196 [details] [diff] [review]
Patch
rs=me, this is too trivial to need SR. Timeless or I will check it in.
/be
Attachment #138196 -
Flags: superreview?(brendan) → superreview+
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 11•21 years ago
|
||
Opps, meant to assign this to me.....
Assignee: BradleyJunk → d_king
Status: ASSIGNED → NEW
|
||
Comment 12•21 years ago
|
||
Comment on attachment 138196 [details] [diff] [review]
Patch
mozilla/js/src/xpconnect/src/xpcprivate.h 1.143
|
|
Assignee | |
Comment 13•21 years ago
|
||
Thanks timeless.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•