Closed Bug 224650 Opened 20 years ago Closed 20 years ago

nsXPCOM.h included twice

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: d_king, Assigned: d_king)

Details

Attachments

(1 file)

Patch
630 bytes, patch
edburns
: review+
brendan
: superreview+
Details | Diff | Splinter Review 
In mozilla/js/src/xpconnect/src/xpcprivate.h , there are two includes of nsXPCOM.h
Severity: normal → trivial
Taking
Assignee: idk → d_king
Attached patch Patch — — Splinter Review 
Removes duplicate include.
Comment on attachment 138196 [details] [diff] [review]
Patch

Asking for "r".
Attachment #138196 - Flags: review?(edburns)
Comment on attachment 138196 [details] [diff] [review]
Patch

r=edburns
Attachment #138196 - Flags: review?(edburns) → review+
Comment on attachment 138196 [details] [diff] [review]
Patch

Asking for "SR", keeping in mind that I have no check-in privs.
Attachment #138196 - Flags: superreview?(idk)
Is not it wrong 'component' for this bug ?
This bug has nothing todo with Java to XPCOM bridge.
Java is not JavaScript

Please reassign this bug to correct component.

Thanks,
  igor
Opps, that was a silly mistake on my part.

Changing component.
Assignee: d_king → general
Component: Java to XPCOM Bridge → JavaScript Engine
QA Contact: avm → PhilSchwartau
Comment on attachment 138196 [details] [diff] [review]
Patch

Changing SR request to match correct Component.
Attachment #138196 - Flags: superreview?(Igor.Kushnirskiy) → superreview?(brendan)
Wrong component, still.

/be
Assignee: general → BradleyJunk
Component: JavaScript Engine → XPConnect
Comment on attachment 138196 [details] [diff] [review]
Patch

rs=me, this is too trivial to need SR.	Timeless or I will check it in.

/be
Attachment #138196 - Flags: superreview?(brendan) → superreview+
Status: NEW → ASSIGNED
Opps, meant to assign this to me.....
Assignee: BradleyJunk → d_king
Status: ASSIGNED → NEW
Comment on attachment 138196 [details] [diff] [review]
Patch

mozilla/js/src/xpconnect/src/xpcprivate.h	1.143
Thanks timeless.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.