224695 - Checksetup.pl errors when setting an existing user as the admin

Status: RESOLVED DUPLICATE of bug 312386

(Bugzilla :: Installation & Upgrading, defect)

Description

[Jouni Heikniemi]

I ran checksetup and entered an email address of an existing user as the
administrator address. Answered "y" when asked if I want to make this user an
admin. Then I was hit by the following:

[Tue Nov  4 18:35:32 2003] checksetup.pl: DBD::mysql::db do failed: Duplicate
entry '6-1-1' for key 1 at checksetup.pl line 4053,
<STDIN> chunk 2.
[Tue Nov  4 18:35:32 2003] checksetup.pl: DBD::mysql::db do failed: Duplicate
entry '6-2-1' for key 1 at checksetup.pl line 4053,
<STDIN> chunk 2.
[Tue Nov  4 18:35:32 2003] checksetup.pl: DBD::mysql::db do failed: Duplicate
entry '6-3-1' for key 1 at checksetup.pl line 4053,
<STDIN> chunk 2.
[Tue Nov  4 18:35:32 2003] checksetup.pl: DBD::mysql::db do failed: Duplicate
entry '6-4-1' for key 1 at checksetup.pl line 4053,
<STDIN> chunk 2.
[Tue Nov  4 18:35:32 2003] checksetup.pl: DBD::mysql::db do failed: Duplicate
entry '6-5-1' for key 1 at checksetup.pl line 4053,
<STDIN> chunk 2.
[Tue Nov  4 18:35:32 2003] checksetup.pl: DBD::mysql::db do failed: Duplicate
entry '6-6-1' for key 1 at checksetup.pl line 4053,
<STDIN> chunk 2.
[Tue Nov  4 18:35:32 2003] checksetup.pl: DBD::mysql::db do failed: Duplicate
entry '6-7-1' for key 1 at checksetup.pl line 4053,
<STDIN> chunk 2.
[Tue Nov  4 18:35:32 2003] checksetup.pl: DBD::mysql::db do failed: Duplicate
entry '6-8-1' for key 1 at checksetup.pl line 4053,
<STDIN> chunk 2.


The line numbers are a bit off from the CVS tip because of custom patches, but
the line is the following:

        $dbh->do("INSERT INTO group_group_map
            (member_id, grantor_id, isbless)
            VALUES ($id, $group, 1)");

If I understand this correctly, checksetup is trying to readd the bless
relations between admin and other administrative groups. These shouldn't be
added unless they're missing for some reason (if even then -- is this just a
system default or an enforced policy? -- maybe the correct resolution is to just
add these relations when first adding the admin group).

Comment 1

[Joel Peshkin]

I think the point about the default is correct.  We should ensure that the admin
group is set up only when it is added.  However, we should also make sure that
the specified user could never have been locked out by carelessly applying
changes to the admin group.  Should we ....

a) Always ensure that the admin group has "editusers" anyway??

b) Always specifically grant membership in editusers to the named admimistrator??

c) Only do (b) if the admin would otherwise not have editusers capability??

d) Just laugh at anyone who locks himself out??

Comment 2

[Jouni Heikniemi]

I'd go for D. When we see the first instance of somebody having locked himself
out, let's fix it then. I mean, this turns into a patchfest if we start fixing
editgroups and editusers for all the possible situations where this sort of
problems might occur.

Besides, in some situations disabling editusers totally might be intentional (as
an additional security measure).

Comment 3

[Frédéric Buclin]

Jouni, can you still reproduce using 2.19.3+ ?

Comment 4

[Frédéric Buclin]

*** This bug has been marked as a duplicate of 312386 ***