[FIX] thumbnails on browse.deviantart.com aren't spaced out

RESOLVED FIXED

Status

()

--
major
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: jruderman, Assigned: mats)

Tracking

({regression, testcase})

Trunk
x86
All
regression, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

15 years ago
1. Load http://browse.deviantart.com/
Expected: spaced-out images.
Result: images are all on the left side, and there's a big gap at the right.

This regressed between the 11/03 and 11/04 official Firebird builds.

No testcase yet, guessing Layout:Block&Inline because the links seem to have
shrunk vertically too.
(Reporter)

Updated

15 years ago
Summary: thumbnails on http://browse.deviantart.com/ aren't spaced out → thumbnails on browse.deviantart.com aren't spaced out
(Reporter)

Comment 1

15 years ago
Originally reported at http://forums.mozillazine.org/viewtopic.php?t=33124.
(Assignee)

Comment 2

15 years ago
This is a regression from bug 224188
Assignee: block-and-inline → dbaron
Severity: minor → major
Component: Layout: Block & Inline → Style System (CSS)
Keywords: testcase
OS: Windows XP → All
(Assignee)

Comment 3

15 years ago
Created attachment 134811 [details]
Testcase
(Assignee)

Comment 4

15 years ago
-    if (GetToken(aErrorCode, PR_TRUE)) {
-      if ((eCSSToken_Symbol == mToken.mType) && 
-          (('+' == mToken.mSymbol) || ('>' == mToken.mSymbol))) {

+    if (eCSSToken_Symbol == mToken.mType && 
+        ('+' == mToken.mSymbol) || ('>' == mToken.mSymbol)) {


Umm, someone needs to read his K&R again... ;-)
Overparenthesizing the == expressions just helps add paren-noise, hiding the
lack of needed parens around the || expression, to make it the right operand of
&&.  Where is that code from?
 
/be
(Assignee)

Comment 6

15 years ago
That was from the patch in bug 224188, which only changed one file:
content/html/style/src/nsCSSParser.cpp
Summary: thumbnails on browse.deviantart.com aren't spaced out → [FIX] thumbnails on browse.deviantart.com aren't spaced out
(Assignee)

Comment 7

15 years ago
Created attachment 134814 [details] [diff] [review]
Patch rev. 1
(Assignee)

Updated

15 years ago
Attachment #134814 - Flags: superreview?(dbaron)
Attachment #134814 - Flags: review?(bz-vacation)
Comment on attachment 134814 [details] [diff] [review]
Patch rev. 1

r+sr=bzbarsky.	The code was overparenthesized, and I deparenthesized it
incorrectly...
Attachment #134814 - Flags: superreview?(dbaron)
Attachment #134814 - Flags: superreview+
Attachment #134814 - Flags: review?(bz-vacation)
Attachment #134814 - Flags: review+
To Mats.
Assignee: dbaron → mats.palmgren
Fix checked in (and testcase added to regression tests).  Thanks for the patch,
Mats!
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.