224818 - Firebird version string reads 1.4a (should be 0.7.1)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[J.J. Enser]

A couple of version strings need to be updated in Info.plist for the Finder to
display Firebird's version properly.

patch will follow shortly.

Comment 1

[J.J. Enser]

Attachment: update CFBundleGetInfoString and CFBundleShortVersionString in Info.plist to reflect current version number

Comment 2

[riscky]

isn't this supoosed to be auto updated?

Comment 3

[Jonathan Louie]

a previous incarnation of this bug (bug 206187) was marked duplicate of bug
180759.  i think they do intend to fix this in the build process so that it
happens automatically.  feel free to mark as dupe if you think appropriate.

Comment 4

[Jonathan Louie]

*** Bug 224946 has been marked as a duplicate of this bug. ***

Comment 5

[Bill Mason]

*** Bug 225258 has been marked as a duplicate of this bug. ***

Comment 6

[Brian Ryner (not reading)]

Attachment: centralize firebird version

So, this is one thing we could do to keep everything in sync in the future.  It
adds a browser/configure script which substitutes the version number into the
appropriate files.

Comment 7

[Asa Dotzler [:asa]]

Sweet! Let's get this in. 

Leaf, can you use this or something like it for SeaMonkey?

Comment 8

[Brian Ryner (not reading)]

Attachment: alternate patch

I'm going to do this instead, to avoid the problem in the previous patch where
the .dtd is not regenerated when the .dtd.in changes.

Comment 9

[Brian Ryner (not reading)]

checked in.

Comment 10

[Takanori MATSUURA]

In the latest trunk build, Info.plist is not build properly.

In mozilla/app/macbuild/Contents/Info.plist.in, @BORWSER_VERSION@ seems to be
set but not replaced.

Comment 11

[Martin Creutziger [:MMx]]

I still seeing the problem in the 0.8 BRANCH build (pulled from CVS 2004-01-22
~10:00 UTC)
Version and short Version show 1.4a (should be 1.6) and BundleString shows 0.6.1
(should be 0.7+)
I hope it gets fixed for 0.8 final, it is very irritation to see a nearly-0.8
Firebird identified as "1.4a".

Comment 12

[Scott MacGregor]

cc'ing myself. I just checked in a similar system for thunderbird. I want to
track this bug in case there are any problems with the patch.

Comment 13

[Takanori MATSUURA]

Attachment: omit @ marks

@APP_VERSION@ should be changed to APP_VERSION.

Comment 14

[Takanori MATSUURA]

Hi Brian.

Your patch in mozilla/browser/app/macbuild/Contents/Info.plist.in is not good.

You set two "<string>@APP_VERSION@</string>" 
at the line 85 and 136 in mozilla/browser/app/macbuild/Contents/Info.plist.
These should be set to "<string>APP_VERSION</string>".

Please check and fix as attachment 139981 [details] [diff] [review].
http://lxr.mozilla.org/mozilla/source/browser/app/macbuild/Contents/Info.plist.in

Comment 15

[Brian Ryner (not reading)]

Comment on attachment 139981 [details] [diff] [review]
omit @ marks

Looks good, and you actually missed a few other places.  I checked in the fix.